aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Jarred Sumner <jarred@jarredsumner.com> 2021-05-28 13:32:55 -0700
committerGravatar Jarred Sumner <jarred@jarredsumner.com> 2021-05-28 13:32:55 -0700
commit91d6bf26b938e47205fc9517d11ac83265fa64b1 (patch)
treed8626d8a76c43c2c7c76dcc6432666c5734047ea
parent2172f3c5e367e604349ad17866f7408ac259ca73 (diff)
downloadbun-91d6bf26b938e47205fc9517d11ac83265fa64b1.tar.gz
bun-91d6bf26b938e47205fc9517d11ac83265fa64b1.tar.zst
bun-91d6bf26b938e47205fc9517d11ac83265fa64b1.zip
Remove legacy_octal_loc
-rw-r--r--src/js_lexer.zig2
-rw-r--r--src/js_parser/js_parser.zig33
2 files changed, 6 insertions, 29 deletions
diff --git a/src/js_lexer.zig b/src/js_lexer.zig
index 132268f10..fef12bf47 100644
--- a/src/js_lexer.zig
+++ b/src/js_lexer.zig
@@ -58,7 +58,6 @@ pub const Lexer = struct {
end: usize = 0,
did_panic: bool = false,
approximate_newline_count: i32 = 0,
- legacy_octal_loc: logger.Loc = logger.Loc.Empty,
previous_backslash_quote_in_jsx: logger.Range = logger.Range.None,
token: T = T.t_end_of_file,
has_newline_before: bool = false,
@@ -95,7 +94,6 @@ pub const Lexer = struct {
.end = self.end,
.did_panic = self.did_panic,
.approximate_newline_count = self.approximate_newline_count,
- .legacy_octal_loc = self.legacy_octal_loc,
.previous_backslash_quote_in_jsx = self.previous_backslash_quote_in_jsx,
.token = self.token,
.has_newline_before = self.has_newline_before,
diff --git a/src/js_parser/js_parser.zig b/src/js_parser/js_parser.zig
index be5cc6a36..ec9883f3f 100644
--- a/src/js_parser/js_parser.zig
+++ b/src/js_parser/js_parser.zig
@@ -6022,12 +6022,6 @@ pub const P = struct {
.e_string => {
const str = expr.value.getString();
if (!str.prefer_template) {
- // stmt.data = Stmt.Data{
- // .s_directive = p.m(S.Directive{
- // .value = str.value,
- // // .legacy_octal_loc = str.legacy_octal_loc,
- // }),
- // };
isDirectivePrologue = true;
if (strings.eqlUtf16("use strict", str.value)) {
@@ -7296,12 +7290,11 @@ pub const P = struct {
return true;
}
- pub fn parseTemplateParts(p: *P, include_raw: bool) anyerror!TemplatePartTuple {
+ pub fn parseTemplateParts(p: *P, include_raw: bool) ![]E.TemplatePart {
var parts = List(E.TemplatePart).initCapacity(p.allocator, 1) catch unreachable;
// Allow "in" inside template literals
var oldAllowIn = p.allow_in;
p.allow_in = true;
- var legacy_octal_loc = logger.Loc.Empty;
parseTemplatePart: while (true) {
try p.lexer.next();
@@ -7326,16 +7319,12 @@ pub const P = struct {
p.allow_in = oldAllowIn;
- return TemplatePartTuple{ .@"0" = parts.toOwnedSlice(), .@"1" = legacy_octal_loc };
+ return parts.toOwnedSlice();
}
// This assumes the caller has already checked for TStringLiteral or TNoSubstitutionTemplateLiteral
pub fn parseStringLiteral(p: *P) anyerror!Expr {
- var legacy_octal_loc: logger.Loc = logger.Loc.Empty;
- var loc = p.lexer.loc();
- if (p.lexer.legacy_octal_loc.start > loc.start) {
- legacy_octal_loc = p.lexer.legacy_octal_loc;
- }
+ const loc = p.lexer.loc();
var str = p.lexer.toEString();
str.prefer_template = p.lexer.token == .t_no_substitution_template_literal;
@@ -7573,7 +7562,6 @@ pub const P = struct {
left = p.e(E.Template{
.tag = left,
.head = head,
- .legacy_octal_loc = logger.Loc.Empty,
}, left.loc);
},
.t_template_head => {
@@ -7584,7 +7572,7 @@ pub const P = struct {
const head = p.lexer.toEString();
const partsGroup = try p.parseTemplateParts(true);
const tag = left;
- left = p.e(E.Template{ .tag = tag, .head = head, .parts = partsGroup.@"0" }, left.loc);
+ left = p.e(E.Template{ .tag = tag, .head = head, .parts = partsGroup }, left.loc);
},
.t_open_bracket => {
// When parsing a decorator, ignore EIndex expressions since they may be
@@ -8333,25 +8321,16 @@ pub const P = struct {
return try p.parseStringLiteral();
},
.t_template_head => {
- var legacy_octal_loc = logger.Loc.Empty;
var head = p.lexer.toEString();
- if (p.lexer.legacy_octal_loc.start > loc.start) {
- legacy_octal_loc = p.lexer.legacy_octal_loc;
- }
- var resp = try p.parseTemplateParts(false);
- const parts: []E.TemplatePart = resp.@"0";
- const tail_legacy_octal_loc: logger.Loc = resp.@"1";
- if (tail_legacy_octal_loc.start > 0) {
- legacy_octal_loc = tail_legacy_octal_loc;
- }
+ const parts = try p.parseTemplateParts(false);
+
// Check if TemplateLiteral is unsupported. We don't care for this product.`
// if ()
return p.e(E.Template{
.head = head,
.parts = parts,
- .legacy_octal_loc = legacy_octal_loc,
}, loc);
},
.t_numeric_literal => {
ns'>+140 2023-07-28Add todoGravatar Jarred Sumner 2-0/+8 2023-07-28Update pull_request_template.mdGravatar Jarred Sumner 1-1/+1 2023-07-28Update pull_request_template.mdGravatar Jarred Sumner 1-11/+16 2023-07-27Fix bug with // @bun annotation in main thread (#3855)Gravatar Jarred Sumner 4-2/+53 2023-07-27Add `Bun.isMainThread`Gravatar Jarred Sumner 7-3/+48 2023-07-27Uncomment testGravatar Jarred Sumner 1-1/+1 2023-07-27Resolve watch directories outside main thread + async iterator and symlink fi...Gravatar Ciro Spaciari 8-197/+523 2023-07-27Update pull_request_template.mdGravatar Jarred Sumner 1-1/+1 2023-07-27Update pull_request_template.mdGravatar Jarred Sumner 1-1/+1 2023-07-27Update pull_request_template.mdGravatar Jarred Sumner 1-1/+1 2023-07-27Update pull_request_template.mdGravatar Jarred Sumner 1-2/+2 2023-07-27Update pull_request_template.mdGravatar Jarred Sumner 1-0/+4 2023-07-27Update pull_request_template.mdGravatar Jarred Sumner 1-5/+11