aboutsummaryrefslogtreecommitdiff
path: root/src/buf/buf_impl.rs
diff options
context:
space:
mode:
authorGravatar Sean McArthur <sean@seanmonstar.com> 2019-10-16 11:28:50 -0700
committerGravatar Carl Lerche <me@carllerche.com> 2019-10-16 11:28:50 -0700
commit491ebbf79a61f78b699e082d2793e79bb17f3f2e (patch)
treeef82ad3ebfafd5501f37f57081c3425dadc243fb /src/buf/buf_impl.rs
parent43ac8e5494e9404327f971937edb092b8cae6a2b (diff)
downloadbytes-491ebbf79a61f78b699e082d2793e79bb17f3f2e.tar.gz
bytes-491ebbf79a61f78b699e082d2793e79bb17f3f2e.tar.zst
bytes-491ebbf79a61f78b699e082d2793e79bb17f3f2e.zip
Remove Buf impl for &str (#301)
A `&str` cannot arbitrarily advance bytes, since it will panic if advanced to the middle of a Unicode segment.
Diffstat (limited to 'src/buf/buf_impl.rs')
-rw-r--r--src/buf/buf_impl.rs21
1 files changed, 2 insertions, 19 deletions
diff --git a/src/buf/buf_impl.rs b/src/buf/buf_impl.rs
index b9e9141..48f8d12 100644
--- a/src/buf/buf_impl.rs
+++ b/src/buf/buf_impl.rs
@@ -903,9 +903,9 @@ pub trait Buf {
/// # Examples
///
/// ```
- /// use bytes::{Buf};
+ /// use bytes::Buf;
///
- /// let bytes = "hello world".to_bytes();
+ /// let bytes = (&b"hello world"[..]).to_bytes();
/// assert_eq!(&bytes[..], &b"hello world"[..]);
/// ```
fn to_bytes(&mut self) -> crate::Bytes {
@@ -971,23 +971,6 @@ impl Buf for &[u8] {
}
}
-impl Buf for &str {
- #[inline]
- fn remaining(&self) -> usize {
- self.len()
- }
-
- #[inline]
- fn bytes(&self) -> &[u8] {
- self.as_bytes()
- }
-
- #[inline]
- fn advance(&mut self, cnt: usize) {
- *self = &self[cnt..];
- }
-}
-
impl Buf for Option<[u8; 1]> {
fn remaining(&self) -> usize {
if self.is_some() {