aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2021-06-16 22:06:45 +0200
committerGravatar Miek Gieben <miek@miek.nl> 2021-06-16 22:06:45 +0200
commit57c3835e201c7dd74df33d7073f3d239f0d3f776 (patch)
tree24f128773fb1819d773a0007df105c26a1e2bcf4
parent6cbd6fdb1fe52c68a161a68cccf7e8b7701303c9 (diff)
downloadcoredns-fallthrough.tar.gz
coredns-fallthrough.tar.zst
coredns-fallthrough.zip
fallthrough: make clear this is a bad ideafallthrough
Update the docs to reflect what's in the docs of plugins/pkg/fallthrough. Closes: #4545 Signed-off-by: Miek Gieben <miek@miek.nl>
-rw-r--r--plugin.md6
1 files changed, 5 insertions, 1 deletions
diff --git a/plugin.md b/plugin.md
index 1973729f2..5c0296646 100644
--- a/plugin.md
+++ b/plugin.md
@@ -125,12 +125,16 @@ In this example the *file* plugin is handling all names below (and including) `e
a query comes in that is not a subdomain (or equal to) `example.org` the next plugin is called.
Now, the world isn't perfect, and there are may be reasons to "fallthrough" to the next plugin,
-meaning a plugin is only responsible for a *subset* of names within the zone.
+meaning a plugin is only responsible for a *subset* of names within the zone. But this is a very
+dangerous route to take, because the multiple sources can have very different ideas on what names
+exist, this can confuse caches and resolvers.
The `fallthrough` directive should optionally accept a list of zones. Only queries for records
in one of those zones should be allowed to fallthrough. See `plugin/pkg/fallthrough` for the
implementation.
+Use this directive should be a last resort and is almost never needed (nor a good idea).
+
## Mutating a Response
Using a custom `ResponseWriter`, a plugin can mutate a response when another plugin further down the chain writes the response to the client.