diff options
| author |  Miek Gieben <miek@miek.nl>
| 2019-11-29 16:22:50 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2019-11-29 16:22:50 +0000 |
| commit | 787b6e06f9b902e9983959f200e843e6fd8c7453 (patch) | |
| tree | 08646858b13bafe87b51d0704722c5a034632314 | |
| parent | b4df2d0d4c2d2014b113f9f8caf1f1b2ed6dc192 (diff) | |
| download | coredns-787b6e06f9b902e9983959f200e843e6fd8c7453.tar.gz coredns-787b6e06f9b902e9983959f200e843e6fd8c7453.tar.zst coredns-787b6e06f9b902e9983959f200e843e6fd8c7453.zip | |
Update governance docs to reflect CODEOWNERS (#3491)
NO GOVERNANCE changes made!
Point to the correct files, now that I merged CODEOWNERS, OWNERS files
are gone and there is also only 1 CODEOWNERS.
Signed-off-by: Miek Gieben <miek@miek.nl>
| -rw-r--r-- | CONTRIBUTING.md | 2 | ||||
| -rw-r--r-- | GOVERNANCE.md | 14 |
2 files changed, 7 insertions, 9 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d3846f664..eeb644cfc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -40,7 +40,7 @@ issue first and "claim" it and get feedback before you invest a lot of time. **If someone already opened a pull request, but you think the pull request has stalled and you would like to open another pull request for the same or similar feature, get some of the maintainers (see -[OWNERS](OWNERS)) involved to resolve the situation and move things forward.** +[CODEOWNERS](CODEOWNERS)) involved to resolve the situation and move things forward.** If possible make a pull request as small as possible, or submit multiple pull request to complete a feature. Smaller means: easier to understand and review. This in turn means things can be merged diff --git a/GOVERNANCE.md b/GOVERNANCE.md index 3171557b0..36c531b58 100644 --- a/GOVERNANCE.md +++ b/GOVERNANCE.md @@ -22,8 +22,8 @@ The term of the project lead is one year, with no term limit restriction. The project lead is elected by CoreDNS maintainers according to an individual's technical merit to CoreDNS project. -The current project lead is identified in the top level [OWNERS](OWNERS) file with the string -`project lead` and the term behind the name. +The current project lead is identified in the [CODEOWNERS](CODEOWNERS) file with the string +`project lead` and the term behind the name in a comment at the top of the file. ## Expectations from Maintainers @@ -35,11 +35,9 @@ participate in Pull Request reviews. Maintainers are expected to respond to assi in a *reasonable* time frame, either providing insights, or assign the Pull Requests to other maintainers. -Every Maintainer is listed in the top-level [OWNERS](https://github.com/coredns/coredns/blob/master/OWNERS) -file, with their Github handle and a possibly obfuscated email address. Everyone in the -`approvers` list is a Maintainer. - -A Maintainer is also listed in a plugin specific OWNERS file. +Every Maintainer is listed in the +[CODEOWNERS](https://github.com/coredns/coredns/blob/master/CODEOWNERS) +file, with their Github handle. A Maintainer should be a member of `maintainers@coredns.io`, although this is not a hard requirement. @@ -66,7 +64,7 @@ Changes in project lead or term is initiated by opening a github PR. Anyone from CoreDNS community can vote on the PR with either +1 or -1. Only the following votes are binding: -1) Any maintainer that has been listed in the top-level [OWNERS](OWNERS) file before the PR is opened. +1) Any maintainer that has been listed in the [CODEOWNERS](CODEOWNERS) file before the PR is opened. 2) Any maintainer from an organization may cast the vote for that organization. However, no organization should have more binding votes than 1/5 of the total number of maintainers defined in 1). |