diff options
| author |  Chris O'Haver <cohaver@infoblox.com>
| 2018-02-13 10:52:56 -0500 |
|---|---|---|
| committer |  John Belamaric <jbelamaric@infoblox.com>
| 2018-02-13 10:52:56 -0500 |
| commit | caf2553d7a39b5f0e69f5b4780c5ff03ff19c883 (patch) | |
| tree | 170c4c712c92031d8a8f498747a569d6d9b2e445 | |
| parent | ca5097ca138553d081c82db24d1cb2baa96bfca3 (diff) | |
| download | coredns-caf2553d7a39b5f0e69f5b4780c5ff03ff19c883.tar.gz coredns-caf2553d7a39b5f0e69f5b4780c5ff03ff19c883.tar.zst coredns-caf2553d7a39b5f0e69f5b4780c5ff03ff19c883.zip | |
fix ptr nxdomain response and test (#1524)
| -rw-r--r-- | plugin/kubernetes/reverse.go | 3 | ||||
| -rw-r--r-- | plugin/kubernetes/reverse_test.go | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/plugin/kubernetes/reverse.go b/plugin/kubernetes/reverse.go index 66e2fc128..e9f6210d8 100644 --- a/plugin/kubernetes/reverse.go +++ b/plugin/kubernetes/reverse.go @@ -18,6 +18,9 @@ func (k *Kubernetes) Reverse(state request.Request, exact bool, opt plugin.Optio } records := k.serviceRecordForIP(ip, state.Name()) + if len(records) == 0 { + return records, errNoItems + } return records, nil } diff --git a/plugin/kubernetes/reverse_test.go b/plugin/kubernetes/reverse_test.go index 22a6219f2..94edef01b 100644 --- a/plugin/kubernetes/reverse_test.go +++ b/plugin/kubernetes/reverse_test.go @@ -155,7 +155,7 @@ func TestReverse(t *testing.T) { }, { Qname: "101.0.0.10.in-addr.arpa.", Qtype: dns.TypePTR, - Rcode: dns.RcodeSuccess, + Rcode: dns.RcodeNameError, Ns: []dns.RR{ test.SOA("0.10.in-addr.arpa. 300 IN SOA ns.dns.0.10.in-addr.arpa. hostmaster.0.10.in-addr.arpa. 1502782828 7200 1800 86400 60"), }, |