aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGravatar Yong Tang <yong.tang.github@outlook.com> 2017-08-09 11:00:03 -0700
committerGravatar Miek Gieben <miek@miek.nl> 2017-08-09 11:00:03 -0700
commitfefc4374d72086d6325019471677a6ae73622a63 (patch)
treee408ea24c1d1451b83ff7ced2c6ff30f4a13ef24
parent654d127a2404b843d3cb305c72c7d2a0433f7cd3 (diff)
downloadcoredns-fefc4374d72086d6325019471677a6ae73622a63.tar.gz
coredns-fefc4374d72086d6325019471677a6ae73622a63.tar.zst
coredns-fefc4374d72086d6325019471677a6ae73622a63.zip
Some `go vet` cleanup (#869)
Some `go vet` cleanup Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
-rw-r--r--middleware/autopath/autopath_test.go4
-rw-r--r--middleware/autopath/setup_test.go2
-rw-r--r--middleware/pkg/dnsutil/zone_test.go2
3 files changed, 3 insertions, 5 deletions
diff --git a/middleware/autopath/autopath_test.go b/middleware/autopath/autopath_test.go
index 5f76dc690..a536ee1fd 100644
--- a/middleware/autopath/autopath_test.go
+++ b/middleware/autopath/autopath_test.go
@@ -132,8 +132,6 @@ func nextHandler(mm map[string]int) test.Handler {
default:
panic("nextHandler: unhandled rcode")
}
-
- return dns.RcodeServerFailure, nil
})
}
@@ -159,7 +157,7 @@ func TestInSearchPath(t *testing.T) {
for i, tc := range tests {
got := a.FirstInSearchPath(tc.qname)
if got != tc.b {
- t.Errorf("Test %d, got %d, expected %d", i, got, tc.b)
+ t.Errorf("Test %d, got %v, expected %v", i, got, tc.b)
}
}
}
diff --git a/middleware/autopath/setup_test.go b/middleware/autopath/setup_test.go
index e01bc312b..0696a9179 100644
--- a/middleware/autopath/setup_test.go
+++ b/middleware/autopath/setup_test.go
@@ -14,7 +14,7 @@ import (
func TestSetupAutoPath(t *testing.T) {
resolv, rm, err := test.TempFile(os.TempDir(), resolvConf)
if err != nil {
- t.Fatalf("Could not create resolv.conf test file: %s", resolvConf, err)
+ t.Fatalf("Could not create resolv.conf test file %s: %s", resolvConf, err)
}
defer rm()
diff --git a/middleware/pkg/dnsutil/zone_test.go b/middleware/pkg/dnsutil/zone_test.go
index 334f3d9d2..81cd1adad 100644
--- a/middleware/pkg/dnsutil/zone_test.go
+++ b/middleware/pkg/dnsutil/zone_test.go
@@ -24,7 +24,7 @@ func TestTrimZone(t *testing.T) {
for i, tc := range tests {
got, err := TrimZone(dns.Fqdn(tc.qname), dns.Fqdn(tc.zone))
if tc.err != nil && err == nil {
- t.Errorf("Test %d, expected error got nil")
+ t.Errorf("Test %d, expected error got nil", i)
continue
}
if tc.err == nil && err != nil {