aboutsummaryrefslogtreecommitdiff
path: root/core/setup/file.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2016-04-27 10:48:22 +0000
committerGravatar Miek Gieben <miek@miek.nl> 2016-04-27 10:48:22 +0000
commit7a8d943bccc7ec0d21e13374c836cf9197996e10 (patch)
tree6d1647d65cdea0376a5eb818e262af2ac670527f /core/setup/file.go
parentefd5135ee365fa2ce09cd41815039efff5a8f8e4 (diff)
downloadcoredns-7a8d943bccc7ec0d21e13374c836cf9197996e10.tar.gz
coredns-7a8d943bccc7ec0d21e13374c836cf9197996e10.tar.zst
coredns-7a8d943bccc7ec0d21e13374c836cf9197996e10.zip
Bail out on failure when starting up
Don't silently hide failures, barf on startup. Also add more integration tests that should catch some of these things.
Diffstat (limited to 'core/setup/file.go')
-rw-r--r--core/setup/file.go5
1 files changed, 4 insertions, 1 deletions
diff --git a/core/setup/file.go b/core/setup/file.go
index b535332a7..a0b90c3ca 100644
--- a/core/setup/file.go
+++ b/core/setup/file.go
@@ -54,7 +54,8 @@ func fileParse(c *Controller) (file.Zones, error) {
reader, err := os.Open(fileName)
if err != nil {
- continue
+ // bail out
+ return file.Zones{}, err
}
for i, _ := range origins {
@@ -62,6 +63,8 @@ func fileParse(c *Controller) (file.Zones, error) {
zone, err := file.Parse(reader, origins[i], fileName)
if err == nil {
z[origins[i]] = zone
+ } else {
+ return file.Zones{}, err
}
names = append(names, origins[i])
}