diff options
author | 2016-04-29 07:28:35 +0100 | |
---|---|---|
committer | 2016-04-29 07:28:35 +0100 | |
commit | 9e9d72655d865f2d136ad3b0439735cde53b679f (patch) | |
tree | f0c365ffb5fbe9599374ab2551463d610f79ebd6 /core/setup/metrics.go | |
parent | a1478f891dd6849835973720df6b5651a8ea88fd (diff) | |
download | coredns-9e9d72655d865f2d136ad3b0439735cde53b679f.tar.gz coredns-9e9d72655d865f2d136ad3b0439735cde53b679f.tar.zst coredns-9e9d72655d865f2d136ad3b0439735cde53b679f.zip |
Make middleware survive a restart (#142)
Make middleware that sets up a (http) handler survive a graceful
restart. We calls the middleware's Shutdown function(s). If restart
fails the Start function is called again.
* middleware/health: OK
* middleware/pprof: OK
* middleware/metrics: OK
All restart OK.
Diffstat (limited to 'core/setup/metrics.go')
-rw-r--r-- | core/setup/metrics.go | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/core/setup/metrics.go b/core/setup/metrics.go index e54f5b011..e88d93c86 100644 --- a/core/setup/metrics.go +++ b/core/setup/metrics.go @@ -12,18 +12,19 @@ const addr = "localhost:9153" var metricsOnce sync.Once func Prometheus(c *Controller) (middleware.Middleware, error) { - met, err := parsePrometheus(c) + m, err := parsePrometheus(c) if err != nil { return nil, err } metricsOnce.Do(func() { - c.Startup = append(c.Startup, met.Start) + c.Startup = append(c.Startup, m.Start) + c.Shutdown = append(c.Shutdown, m.Shutdown) }) return func(next middleware.Handler) middleware.Handler { - met.Next = next - return met + m.Next = next + return m }, nil } |