diff options
author | 2016-04-29 07:28:35 +0100 | |
---|---|---|
committer | 2016-04-29 07:28:35 +0100 | |
commit | 9e9d72655d865f2d136ad3b0439735cde53b679f (patch) | |
tree | f0c365ffb5fbe9599374ab2551463d610f79ebd6 /core/sigtrap.go | |
parent | a1478f891dd6849835973720df6b5651a8ea88fd (diff) | |
download | coredns-9e9d72655d865f2d136ad3b0439735cde53b679f.tar.gz coredns-9e9d72655d865f2d136ad3b0439735cde53b679f.tar.zst coredns-9e9d72655d865f2d136ad3b0439735cde53b679f.zip |
Make middleware survive a restart (#142)
Make middleware that sets up a (http) handler survive a graceful
restart. We calls the middleware's Shutdown function(s). If restart
fails the Start function is called again.
* middleware/health: OK
* middleware/pprof: OK
* middleware/metrics: OK
All restart OK.
Diffstat (limited to 'core/sigtrap.go')
-rw-r--r-- | core/sigtrap.go | 24 |
1 files changed, 23 insertions, 1 deletions
diff --git a/core/sigtrap.go b/core/sigtrap.go index 3b74efb02..f40dd971a 100644 --- a/core/sigtrap.go +++ b/core/sigtrap.go @@ -68,4 +68,26 @@ func executeShutdownCallbacks(signame string) (exitCode int) { return } -var shutdownCallbacksOnce sync.Once +// executeStartupCallbacks executes the startup callbacks as initiated +// by signame. This is used when on restart when the child failed to start and +// all middleware executed their shutdown functions +func executeStartupCallbacks(signame string) (exitCode int) { + startupCallbacksOnce.Do(func() { + serversMu.Lock() + errs := server.StartupCallbacks(servers) + serversMu.Unlock() + + if len(errs) > 0 { + for _, err := range errs { + log.Printf("[ERROR] %s shutdown: %v", signame, err) + } + exitCode = 1 + } + }) + return +} + +var ( + shutdownCallbacksOnce sync.Once + startupCallbacksOnce sync.Once +) |