diff options
author | 2017-06-13 12:39:10 -0700 | |
---|---|---|
committer | 2017-06-13 12:39:10 -0700 | |
commit | e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae (patch) | |
tree | 152a04673698e1a39caa751c02612d4e21315662 /middleware/cache/freq/freq.go | |
parent | b1efd3736e6e68ab01baf54f83071c62690899b2 (diff) | |
download | coredns-e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae.tar.gz coredns-e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae.tar.zst coredns-e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae.zip |
New cache implementation and prefetch handing in mw/cache (#731)
* cache: add sharded cache implementation
Add Cache impl and a few tests. This cache is 256-way sharded, mainly
so each shard has it's own lock. The main cache structure is a readonly
jump plane into the right shard.
This should remove the single lock contention on the main lock and
provide more concurrent throughput - Obviously this hasn't been tested
or measured.
The key into the cache was made a uint32 (hash.fnv) and the hashing op
is not using strings.ToLower anymore remove any GC in that code path.
* here too
* Minimum shard size
* typos
* blurp
* small cleanups no defer
* typo
* Add freq based on Johns idea
* cherry-pick conflict resolv
* typo
* update from early code review from john
* add prefetch to the cache
* mw/cache: add prefetch
* remove println
* remove comment
* Fix tests
* Test prefetch in setup
* Add start of cache
* try add diff cache options
* Add hacky testcase
* not needed
* allow the use of a percentage for prefetch
If the TTL falls below xx% do a prefetch, if the record was popular.
Some other fixes and correctly prefetch only popular records.
Diffstat (limited to 'middleware/cache/freq/freq.go')
-rw-r--r-- | middleware/cache/freq/freq.go | 54 |
1 files changed, 54 insertions, 0 deletions
diff --git a/middleware/cache/freq/freq.go b/middleware/cache/freq/freq.go new file mode 100644 index 000000000..528eedc1c --- /dev/null +++ b/middleware/cache/freq/freq.go @@ -0,0 +1,54 @@ +// Package freq keeps track of last X seen events. The events themselves are not stored +// here. So the Freq type should be added next to the thing it is tracking. +package freq + +import ( + "sync" + "time" +) + +type Freq struct { + // Last time we saw a query for this element. + last time.Time + // Number of this in the last time slice. + hits int + + sync.RWMutex +} + +// New returns a new initialized Freq. +func New(t time.Time) *Freq { + return &Freq{last: t, hits: 0} +} + +// Updates updates the number of hits. Last time seen will be set to now. +// If the last time we've seen this entity is within now - d, we increment hits, otherwise +// we reset hits to 1. It returns the number of hits. +func (f *Freq) Update(d time.Duration, now time.Time) int { + earliest := now.Add(-1 * d) + f.Lock() + defer f.Unlock() + if f.last.Before(earliest) { + f.last = now + f.hits = 1 + return f.hits + } + f.last = now + f.hits++ + return f.hits +} + +// Hits returns the number of hits that we have seen, according to the updates we have done to f. +func (f *Freq) Hits() int { + f.RLock() + defer f.RUnlock() + return f.hits +} + +// Reset resets f to time t and hits to hits. +func (f *Freq) Reset(t time.Time, hits int) { + f.Lock() + defer f.Unlock() + f.last = t + f.hits = hits +} |