middleware/cache: rename categories (#321)

Rename: positive -> success
negative -> denial

There is a third (unused category) which is error. Start using these
new in the caching middleware and later in the logging middleware.

1 files changed, 11 insertions, 7 deletions

diff --git a/middleware/cache/setup_test.go b/middleware/cache/setup_test.go
index 493ade5a7..ee8976a49 100644
--- a/middleware/cache/setup_test.go
+++ b/middleware/cache/setup_test.go
@@ -19,22 +19,26 @@ func TestSetup(t *testing.T) {
 		{`cache`, false, defaultCap, defaultCap, maxNTTL, maxTTL},
 		{`cache {}`, false, defaultCap, defaultCap, maxNTTL, maxTTL},
 		{`cache example.nl {
-			positive 10
+			success 10
 		}`, false, defaultCap, 10, maxNTTL, maxTTL},
 		{`cache example.nl {
-			positive 10
-			negative 10 15
+			success 10
+			denial 10 15
 		}`, false, 10, 10, 15 * time.Second, maxTTL},
 		{`cache 25 example.nl {
-			positive 10
-			negative 10 15
+			success 10
+			denial 10 15
 		}`, false, 10, 10, 15 * time.Second, 25 * time.Second},
 		{`cache aaa example.nl`, false, defaultCap, defaultCap, maxNTTL, maxTTL},
 
 		// fails
 		{`cache example.nl {
-			positive
-			negative 10 15
+			success
+			denial 10 15
+		}`, true, defaultCap, defaultCap, maxTTL, maxTTL},
+		{`cache example.nl {
+			success 15
+			denial aaa
 		}`, true, defaultCap, defaultCap, maxTTL, maxTTL},
 		{`cache example.nl {
 			positive 15