diff options
| author |  Miek Gieben <miek@miek.nl>
| 2016-04-04 08:19:06 +0100 |
|---|---|---|
| committer | Miek Gieben <miek@miek.nl>
| 2016-04-04 08:19:06 +0100 |
| commit | 84dfdab58499214df3be14395deb8fc3ff61f9c0 (patch) | |
| tree | b0bfd25e74e28e6a166268f67a6521d0dfca1110 /middleware/errors/errors_test.go | |
| parent | b3b6fe48f665500afc2bf9a51986fc1cc9f9fccc (diff) | |
| download | coredns-84dfdab58499214df3be14395deb8fc3ff61f9c0.tar.gz coredns-84dfdab58499214df3be14395deb8fc3ff61f9c0.tar.zst coredns-84dfdab58499214df3be14395deb8fc3ff61f9c0.zip | |
Cache elements of State
Cache the size and the do bit whenever someone asked for it. We can
probably add more:
PASS
BenchmarkStateDo-4 100000000 11.9 ns/op
BenchmarkStateSize-4 5000000 265 ns/op
ok github.com/miekg/coredns/middleware 2.828s
PASS
BenchmarkStateDo-4 1000000000 2.86 ns/op
BenchmarkStateSize-4 500000000 3.10 ns/op
ok github.com/miekg/coredns/middleware 5.032s
This PR also includes some testing cleanups as well.
Diffstat (limited to 'middleware/errors/errors_test.go')
| -rw-r--r-- | middleware/errors/errors_test.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/middleware/errors/errors_test.go b/middleware/errors/errors_test.go index c0a1dfb7b..00dea1ebb 100644 --- a/middleware/errors/errors_test.go +++ b/middleware/errors/errors_test.go @@ -9,6 +9,7 @@ import ( "testing" "github.com/miekg/coredns/middleware" + coretest "github.com/miekg/coredns/middleware/testing" "github.com/miekg/dns" "golang.org/x/net/context" @@ -46,7 +47,7 @@ func TestErrors(t *testing.T) { for i, test := range tests { em.Next = test.next buf.Reset() - rec := middleware.NewResponseRecorder(&middleware.TestResponseWriter{}) + rec := middleware.NewResponseRecorder(&coretest.ResponseWriter{}) code, err := em.ServeDNS(ctx, rec, req) if err != test.expectedErr { @@ -77,7 +78,7 @@ func TestVisibleErrorWithPanic(t *testing.T) { req := new(dns.Msg) req.SetQuestion("example.org.", dns.TypeA) - rec := middleware.NewResponseRecorder(&middleware.TestResponseWriter{}) + rec := middleware.NewResponseRecorder(&coretest.ResponseWriter{}) code, err := eh.ServeDNS(ctx, rec, req) if code != 0 { |