aboutsummaryrefslogtreecommitdiff
path: root/middleware/errors/errors_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2017-05-31 20:28:53 +0100
committerGravatar GitHub <noreply@github.com> 2017-05-31 20:28:53 +0100
commite261ac1a6e64077e288ca95fbb805c9ce7aafba0 (patch)
tree83ab775280a4d88e09efd5c5de2e88a49c90aec5 /middleware/errors/errors_test.go
parent6c774782e0d47c3e76f8b7339752caab57850710 (diff)
downloadcoredns-e261ac1a6e64077e288ca95fbb805c9ce7aafba0.tar.gz
coredns-e261ac1a6e64077e288ca95fbb805c9ce7aafba0.tar.zst
coredns-e261ac1a6e64077e288ca95fbb805c9ce7aafba0.zip
middleware/{log,errors}: output everything to stdout (#684)
Limit the options in both errors and log middleware, just output to stdout and let someone else (journald,docker) care about where to route the logs. This removes syslog and logging to a file. Fixes #573 #602
Diffstat (limited to 'middleware/errors/errors_test.go')
-rw-r--r--middleware/errors/errors_test.go24
1 files changed, 0 insertions, 24 deletions
diff --git a/middleware/errors/errors_test.go b/middleware/errors/errors_test.go
index 1d389ba47..5e565964c 100644
--- a/middleware/errors/errors_test.go
+++ b/middleware/errors/errors_test.go
@@ -66,30 +66,6 @@ func TestErrors(t *testing.T) {
}
}
-func TestVisibleErrorWithPanic(t *testing.T) {
- const panicMsg = "I'm a panic"
- eh := errorHandler{
- Debug: true,
- Next: middleware.HandlerFunc(func(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
- panic(panicMsg)
- }),
- }
-
- ctx := context.TODO()
- req := new(dns.Msg)
- req.SetQuestion("example.org.", dns.TypeA)
-
- rec := dnsrecorder.New(&test.ResponseWriter{})
-
- code, err := eh.ServeDNS(ctx, rec, req)
- if code != 0 {
- t.Errorf("Expected error handler to return 0 (it should write to response), got status %d", code)
- }
- if err != nil {
- t.Errorf("Expected error handler to return nil error (it should panic!), but got '%v'", err)
- }
-}
-
func genErrorHandler(rcode int, err error) middleware.Handler {
return middleware.HandlerFunc(func(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
return rcode, err