diff options
| author |  Miek Gieben <miek@miek.nl>
| 2017-03-06 11:43:23 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2017-03-06 11:43:23 +0000 |
| commit | d1bb4ea130dc8f5ef478f484e7576c311e5e8d39 (patch) | |
| tree | 2bce9fdd5f5b2a9ad6b8231965784f963dcd29c5 /middleware/etcd/handler.go | |
| parent | 12678ac5e2ff86fa3e40939ee4941aff0b05c0b6 (diff) | |
| download | coredns-d1bb4ea130dc8f5ef478f484e7576c311e5e8d39.tar.gz coredns-d1bb4ea130dc8f5ef478f484e7576c311e5e8d39.tar.zst coredns-d1bb4ea130dc8f5ef478f484e7576c311e5e8d39.zip | |
Don't error log NXDOMAIN (#572)
In both etcd and k8s don't error log NXDOMAIN as this log spams the logs
for no good reason.
Fixes #568
Better long term solution is log rate limiting for both *log* and
*error*.
Diffstat (limited to 'middleware/etcd/handler.go')
| -rw-r--r-- | middleware/etcd/handler.go | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/middleware/etcd/handler.go b/middleware/etcd/handler.go index ac5f11772..cf11f3f86 100644 --- a/middleware/etcd/handler.go +++ b/middleware/etcd/handler.go @@ -89,7 +89,8 @@ func (e *Etcd) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) ( } if e.IsNameError(err) { - return middleware.BackendError(e, zone, dns.RcodeNameError, state, debug, err, opt) + // Make err nil when returning here, so we don't log spam for NXDOMAIN. + return middleware.BackendError(e, zone, dns.RcodeNameError, state, debug, nil /* err */, opt) } if err != nil { return middleware.BackendError(e, zone, dns.RcodeServerFailure, state, debug, err, opt) |