diff options
| author |  Miek Gieben <miek@miek.nl>
| 2016-09-23 09:14:12 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2016-09-23 09:14:12 +0100 |
| commit | 090d1872e92b3becd198f92baa79869389212750 (patch) | |
| tree | 9016e01a543412291ec9656bad26ea880772d0a5 /middleware/file/dnssec_test.go | |
| parent | cacbb0e0b1cfcd7f4e95b76358a5332d6d90e6ea (diff) | |
| download | coredns-090d1872e92b3becd198f92baa79869389212750.tar.gz coredns-090d1872e92b3becd198f92baa79869389212750.tar.zst coredns-090d1872e92b3becd198f92baa79869389212750.zip | |
Golint2 (#280)
* Fix linter errors
* More linting fixes
* More docs and making members private that dont need to be public
* Fix linter errors
* More linting fixes
* More docs and making members private that dont need to be public
* More lint fixes
This leaves:
~~~
middleware/kubernetes/nametemplate/nametemplate.go:64:6: exported type NameTemplate should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:71:1: exported method NameTemplate.SetTemplate should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:108:1: exported method NameTemplate.GetZoneFromSegmentArray should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:116:1: exported method NameTemplate.GetNamespaceFromSegmentArray should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:120:1: exported method NameTemplate.GetServiceFromSegmentArray should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:124:1: exported method NameTemplate.GetTypeFromSegmentArray should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:135:1: exported method NameTemplate.GetSymbolFromSegmentArray should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:167:1: exported method NameTemplate.IsValid should have comment or be unexported
middleware/kubernetes/nametemplate/nametemplate.go:182:6: exported type NameValues should have comment or be unexported
middleware/kubernetes/util/util.go:1:1: package comment should be of the form "Package util ..."
middleware/kubernetes/util/util.go:27:2: exported const WildcardStar should have comment (or a comment on this block) or be unexported
middleware/proxy/lookup.go:66:1: exported method Proxy.Forward should have comment or be unexported
middleware/proxy/proxy.go:24:6: exported type Client should have comment or be unexported
middleware/proxy/proxy.go:107:1: exported function Clients should have comment or be unexported
middleware/proxy/reverseproxy.go:10:6: exported type ReverseProxy should have comment or be unexported
middleware/proxy/reverseproxy.go:16:1: exported method ReverseProxy.ServeDNS should have comment or be unexported
middleware/proxy/upstream.go:42:6: exported type Options should have comment or be unexported
~~~
I plan on reworking the proxy anyway, so I'll leave that be.
Diffstat (limited to 'middleware/file/dnssec_test.go')
| -rw-r--r-- | middleware/file/dnssec_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/middleware/file/dnssec_test.go b/middleware/file/dnssec_test.go index 434ebed8f..63099afb4 100644 --- a/middleware/file/dnssec_test.go +++ b/middleware/file/dnssec_test.go @@ -105,7 +105,7 @@ var dnssecTestCases = []test.Case{ } func TestLookupDNSSEC(t *testing.T) { - zone, err := Parse(strings.NewReader(dbMiekNL_signed), testzone, "stdin") + zone, err := Parse(strings.NewReader(dbMiekNLSigned), testzone, "stdin") if err != nil { t.Fatalf("expect no error when reading zone, got %q", err) } @@ -147,7 +147,7 @@ func TestLookupDNSSEC(t *testing.T) { } func BenchmarkLookupDNSSEC(b *testing.B) { - zone, err := Parse(strings.NewReader(dbMiekNL_signed), testzone, "stdin") + zone, err := Parse(strings.NewReader(dbMiekNLSigned), testzone, "stdin") if err != nil { return } @@ -178,7 +178,7 @@ func BenchmarkLookupDNSSEC(b *testing.B) { } } -const dbMiekNL_signed = ` +const dbMiekNLSigned = ` ; File written on Sun Mar 27 04:13:01 2016 ; dnssec_signzone version 9.10.3-P4-Ubuntu miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. ( |