aboutsummaryrefslogtreecommitdiff
path: root/middleware/file/ent_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2017-08-16 15:30:58 +0100
committerGravatar GitHub <noreply@github.com> 2017-08-16 15:30:58 +0100
commit7f46df6d274eff51569b57b382480301caa1dff6 (patch)
tree4a6062700acc0bd110ef622b64f055a235042294 /middleware/file/ent_test.go
parent65b56248f0f4a43fe71435c4d801b94c3f168f65 (diff)
downloadcoredns-7f46df6d274eff51569b57b382480301caa1dff6.tar.gz
coredns-7f46df6d274eff51569b57b382480301caa1dff6.tar.zst
coredns-7f46df6d274eff51569b57b382480301caa1dff6.zip
tests: add SortAndCheck helper (#926)
There was quite some code duplication in a lot of tests to check if an answer was considered Ok. Created a test.SortAndCheck helper function that takes care of this.
Diffstat (limited to 'middleware/file/ent_test.go')
-rw-r--r--middleware/file/ent_test.go21
1 files changed, 1 insertions, 20 deletions
diff --git a/middleware/file/ent_test.go b/middleware/file/ent_test.go
index f8e5da4fe..433aa182d 100644
--- a/middleware/file/ent_test.go
+++ b/middleware/file/ent_test.go
@@ -1,7 +1,6 @@
package file
import (
- "sort"
"strings"
"testing"
@@ -51,25 +50,7 @@ func TestLookupEnt(t *testing.T) {
}
resp := rec.Msg
- sort.Sort(test.RRSet(resp.Answer))
- sort.Sort(test.RRSet(resp.Ns))
- sort.Sort(test.RRSet(resp.Extra))
-
- if !test.Header(t, tc, resp) {
- t.Logf("%v\n", resp)
- continue
- }
-
- if !test.Section(t, tc, test.Answer, resp.Answer) {
- t.Logf("%v\n", resp)
- }
- if !test.Section(t, tc, test.Ns, resp.Ns) {
- t.Logf("%v\n", resp)
-
- }
- if !test.Section(t, tc, test.Extra, resp.Extra) {
- t.Logf("%v\n", resp)
- }
+ test.SortAndCheck(t, resp, tc)
}
}