diff options
| author |  Miek Gieben <miek@miek.nl>
| 2017-06-08 18:43:11 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2017-06-08 18:43:11 +0100 |
| commit | 990460ee7caffe752167b5307d7a5bffab37da61 (patch) | |
| tree | 59dcbc4047b63eb95a1aaaa1ae2c4051bd6fee15 /middleware/file/reload_test.go | |
| parent | 1c45e262f5cf20aaa950f8e8d86248cbce6ae120 (diff) | |
| download | coredns-990460ee7caffe752167b5307d7a5bffab37da61.tar.gz coredns-990460ee7caffe752167b5307d7a5bffab37da61.tar.zst coredns-990460ee7caffe752167b5307d7a5bffab37da61.zip | |
middleware/file: don't reload zone when SOA isn't changed (#707)
* middleware/file: don't reload zone when SOA isn't changed
Give Parse an extra argument which is the SOA's serial, if > 0 we check
against the just parsed SOA and then just return.
Most notable use is in reload.go which is both used in the file and auto
middleware.
Fixes #415
* PR comments
Diffstat (limited to 'middleware/file/reload_test.go')
| -rw-r--r-- | middleware/file/reload_test.go | 13 |
1 files changed, 11 insertions, 2 deletions
diff --git a/middleware/file/reload_test.go b/middleware/file/reload_test.go index 77e644417..c4d065155 100644 --- a/middleware/file/reload_test.go +++ b/middleware/file/reload_test.go @@ -4,6 +4,7 @@ import ( "io/ioutil" "log" "os" + "strings" "testing" "time" @@ -25,7 +26,7 @@ func TestZoneReload(t *testing.T) { if err != nil { t.Fatalf("failed to open zone: %s", err) } - z, err := Parse(reader, "miek.nl", fileName) + z, err := Parse(reader, "miek.nl", fileName, 0) if err != nil { t.Fatalf("failed to parse zone: %s", err) } @@ -60,6 +61,14 @@ func TestZoneReload(t *testing.T) { } } +func TestZoneReloadSOAChange(t *testing.T) { + _, err := Parse(strings.NewReader(reloadZoneTest), "miek.nl.", "stdin", 1460175181) + if err == nil { + t.Fatalf("zone should not have been re-parsed") + } + +} + const reloadZoneTest = `miek.nl. 1627 IN SOA linode.atoom.net. miek.miek.nl. 1460175181 14400 3600 604800 14400 miek.nl. 1627 IN NS ext.ns.whyscream.net. miek.nl. 1627 IN NS omval.tednet.nl. @@ -67,7 +76,7 @@ miek.nl. 1627 IN NS linode.atoom.net. miek.nl. 1627 IN NS ns-ext.nlnetlabs.nl. ` -const reloadZone2Test = `miek.nl. 1627 IN SOA linode.atoom.net. miek.miek.nl. 1460175181 14400 3600 604800 14400 +const reloadZone2Test = `miek.nl. 1627 IN SOA linode.atoom.net. miek.miek.nl. 1460175182 14400 3600 604800 14400 miek.nl. 1627 IN NS ext.ns.whyscream.net. miek.nl. 1627 IN NS omval.tednet.nl. ` |