diff options
| author |  Miek Gieben <miek@miek.nl>
| 2017-09-07 18:21:37 +0100 |
|---|---|---|
| committer |  John Belamaric <jbelamaric@infoblox.com>
| 2017-09-07 13:21:37 -0400 |
| commit | bcdc99ab11b4fb6c6ebb06cfa0ae15ed269ad02e (patch) | |
| tree | a2bb73af02a25df1be7fa99afcdc28b91d260e64 /middleware/kubernetes/handler.go | |
| parent | 594c6d7522087f81d1e43f47efe20688b9e44598 (diff) | |
| download | coredns-bcdc99ab11b4fb6c6ebb06cfa0ae15ed269ad02e.tar.gz coredns-bcdc99ab11b4fb6c6ebb06cfa0ae15ed269ad02e.tar.zst coredns-bcdc99ab11b4fb6c6ebb06cfa0ae15ed269ad02e.zip | |
mw/etcd: fix 'fallthrough' (#1026)
* mw/etcd: revert 'add fallthrough'
This removes 'fallthrough' for *etcd* which is not needed. This was
added in 00f5c7797 but is totally not needed and creates backwards
incompat behavior even.
Thanks to @johnbelamaric for pointing this out in #925.
* remove here as well
* Revert "remove here as well"
This reverts commit 9d44397827425e567af01d43564c4294b42e98c9.
* Revert "mw/etcd: revert 'add fallthrough'"
This reverts commit 0cfe3cb1ab5495ed38a8a0486e3f5386f3bd95dc.
* mw/{etcd,kubernetes}: use fallthrough correctly
reverts of reverts, will rebase and squash later.
Diffstat (limited to 'middleware/kubernetes/handler.go')
| -rw-r--r-- | middleware/kubernetes/handler.go | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/middleware/kubernetes/handler.go b/middleware/kubernetes/handler.go index b6cc703b7..58aecfe1a 100644 --- a/middleware/kubernetes/handler.go +++ b/middleware/kubernetes/handler.go @@ -19,10 +19,7 @@ func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.M zone := middleware.Zones(k.Zones).Matches(state.Name()) if zone == "" { - if k.Fallthrough { - return middleware.NextOrFailure(k.Name(), k.Next, ctx, w, r) - } - return dns.RcodeServerFailure, nil + return middleware.NextOrFailure(k.Name(), k.Next, ctx, w, r) } state.Zone = zone |