aboutsummaryrefslogtreecommitdiff
path: root/middleware/kubernetes/handler.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2017-03-06 11:43:23 +0000
committerGravatar GitHub <noreply@github.com> 2017-03-06 11:43:23 +0000
commitd1bb4ea130dc8f5ef478f484e7576c311e5e8d39 (patch)
tree2bce9fdd5f5b2a9ad6b8231965784f963dcd29c5 /middleware/kubernetes/handler.go
parent12678ac5e2ff86fa3e40939ee4941aff0b05c0b6 (diff)
downloadcoredns-d1bb4ea130dc8f5ef478f484e7576c311e5e8d39.tar.gz
coredns-d1bb4ea130dc8f5ef478f484e7576c311e5e8d39.tar.zst
coredns-d1bb4ea130dc8f5ef478f484e7576c311e5e8d39.zip
Don't error log NXDOMAIN (#572)
In both etcd and k8s don't error log NXDOMAIN as this log spams the logs for no good reason. Fixes #568 Better long term solution is log rate limiting for both *log* and *error*.
Diffstat (limited to 'middleware/kubernetes/handler.go')
-rw-r--r--middleware/kubernetes/handler.go3
1 files changed, 2 insertions, 1 deletions
diff --git a/middleware/kubernetes/handler.go b/middleware/kubernetes/handler.go
index b86938d26..9dfc5c5a0 100644
--- a/middleware/kubernetes/handler.go
+++ b/middleware/kubernetes/handler.go
@@ -71,7 +71,8 @@ func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.M
_, _, err = middleware.A(&k, zone, state, nil, middleware.Options{})
}
if k.IsNameError(err) {
- return middleware.BackendError(&k, zone, dns.RcodeNameError, state, nil /*debug*/, err, middleware.Options{})
+ // Make err nil when returning here, so we don't log spam for NXDOMAIN.
+ return middleware.BackendError(&k, zone, dns.RcodeNameError, state, nil /*debug*/, nil /* err */, middleware.Options{})
}
if err != nil {
return dns.RcodeServerFailure, err