diff options
| author |  Miek Gieben <miek@miek.nl>
| 2017-08-06 05:54:24 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2017-08-06 05:54:24 -0700 |
| commit | bcb2eb1ecc79b2721dc5a2e0cca64008b601e431 (patch) | |
| tree | a2721b7dcf51dfac57f4e19d37d06ebc0c991973 /middleware/kubernetes/handler_test.go | |
| parent | 964f04f4433772795fd76711020c5616bad5b915 (diff) | |
| download | coredns-bcb2eb1ecc79b2721dc5a2e0cca64008b601e431.tar.gz coredns-bcb2eb1ecc79b2721dc5a2e0cca64008b601e431.tar.zst coredns-bcb2eb1ecc79b2721dc5a2e0cca64008b601e431.zip | |
all: gometalinter (#843)
* kubernetes/reverse: remove deadcode
* deadcode in errors and kubernetes removed
* unnecessary conversion
* constants
* proxy: time.Since()
* simplications
* static check
* Disable test/external_test
Diffstat (limited to 'middleware/kubernetes/handler_test.go')
| -rw-r--r-- | middleware/kubernetes/handler_test.go | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/middleware/kubernetes/handler_test.go b/middleware/kubernetes/handler_test.go index 9e38bc59f..04d64722f 100644 --- a/middleware/kubernetes/handler_test.go +++ b/middleware/kubernetes/handler_test.go @@ -273,32 +273,32 @@ func TestServeDNS(t *testing.T) { k.Next = testHandler(nextMWMap) ctx := context.TODO() - runServeDNSTests(t, dnsTestCases, k, ctx) - runServeDNSTests(t, autopathCases, k, ctx) - runServeDNSTests(t, autopathBareSearch, k, ctx) + runServeDNSTests(ctx, t, dnsTestCases, k) + runServeDNSTests(ctx, t, autopathCases, k) + runServeDNSTests(ctx, t, autopathBareSearch, k) //Set PodMode to Disabled k.PodMode = PodModeDisabled - runServeDNSTests(t, podModeDisabledCases, k, ctx) + runServeDNSTests(ctx, t, podModeDisabledCases, k) //Set PodMode to Insecure k.PodMode = PodModeInsecure - runServeDNSTests(t, podModeInsecureCases, k, ctx) + runServeDNSTests(ctx, t, podModeInsecureCases, k) //Set PodMode to Verified k.PodMode = PodModeVerified - runServeDNSTests(t, podModeVerifiedCases, k, ctx) + runServeDNSTests(ctx, t, podModeVerifiedCases, k) // Set ndots to 2 for the ndots test cases k.AutoPath.NDots = 2 - runServeDNSTests(t, autopath2NDotsCases, k, ctx) + runServeDNSTests(ctx, t, autopath2NDotsCases, k) k.AutoPath.NDots = defautNdots // Disable the NXDOMAIN override (enabled by default) k.OnNXDOMAIN = dns.RcodeNameError - runServeDNSTests(t, autopathCases, k, ctx) - runServeDNSTests(t, autopathBareSearchExpectNameErr, k, ctx) + runServeDNSTests(ctx, t, autopathCases, k) + runServeDNSTests(ctx, t, autopathBareSearchExpectNameErr, k) } -func runServeDNSTests(t *testing.T, dnsTestCases map[string](*test.Case), k Kubernetes, ctx context.Context) { +func runServeDNSTests(ctx context.Context, t *testing.T, dnsTestCases map[string](*test.Case), k Kubernetes) { for testname, tc := range dnsTestCases { testname = "\nTest Case \"" + testname + "\"" r := tc.Msg() |