all: gometalinter (#843)

* kubernetes/reverse: remove deadcode
* deadcode in errors and kubernetes removed
* unnecessary conversion
* constants
* proxy: time.Since()
* simplications
* static check
* Disable test/external_test

1 files changed, 6 insertions, 14 deletions

diff --git a/middleware/kubernetes/kubernetes.go b/middleware/kubernetes/kubernetes.go
index 016cfc403..3649eb02c 100644
--- a/middleware/kubernetes/kubernetes.go
+++ b/middleware/kubernetes/kubernetes.go
@@ -100,13 +100,12 @@ type recordRequest struct {
 }
 
 var (
-	errNoItems           = errors.New("no items found")
-	errNsNotExposed      = errors.New("namespace is not exposed")
-	errInvalidRequest    = errors.New("invalid query name")
-	errZoneNotFound      = errors.New("zone not found")
-	errAPIBadPodType     = errors.New("expected type *api.Pod")
-	errPodsDisabled      = errors.New("pod records disabled")
-	errResolvConfReadErr = errors.New("resolv.conf read error")
+	errNoItems        = errors.New("no items found")
+	errNsNotExposed   = errors.New("namespace is not exposed")
+	errInvalidRequest = errors.New("invalid query name")
+	errZoneNotFound   = errors.New("zone not found")
+	errAPIBadPodType  = errors.New("expected type *api.Pod")
+	errPodsDisabled   = errors.New("pod records disabled")
 )
 
 // Services implements the ServiceBackend interface.
@@ -468,13 +467,6 @@ func (k *Kubernetes) getRecordsForK8sItems(services []service, pods []pod, r rec
 	return records
 }
 
-func ipFromPodName(podname string) string {
-	if strings.Count(podname, "-") == 3 && !strings.Contains(podname, "--") {
-		return strings.Replace(podname, "-", ".", -1)
-	}
-	return strings.Replace(podname, "-", ":", -1)
-}
-
 func (k *Kubernetes) findPodWithIP(ip string) (p *api.Pod) {
 	if !k.AutoPath.Enabled {
 		return nil