middleware/metrics: fix crash on startup (#318)

Make the methods that handle Metrics all use pointer receivers to fix
sync.Once not being initialized.

Finish the setup_test to test for failures. And make the check for the
address more strict and return an error when it does not have a port
number.

Add a toplevel test that starts a CoreDNS server with metrics enabled
so we catch these errors in the future.

1 files changed, 1 insertions, 1 deletions

diff --git a/middleware/metrics/metrics.go b/middleware/metrics/metrics.go
index d8af7f7c5..b82a2be86 100644
--- a/middleware/metrics/metrics.go
+++ b/middleware/metrics/metrics.go
@@ -32,7 +32,7 @@ type Metrics struct {
 	Addr      string
 	ln        net.Listener
 	mux       *http.ServeMux
-	Once      *sync.Once
+	Once      sync.Once
 	ZoneNames []string
 }