aboutsummaryrefslogtreecommitdiff
path: root/middleware/metrics/metrics_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2016-10-28 12:57:10 +0100
committerGravatar GitHub <noreply@github.com> 2016-10-28 12:57:10 +0100
commitcb867ff6bda5a3964a7ffc767cbeeb0b789259be (patch)
tree8dd08149646afa5e0be09ee1058ba4e81320d708 /middleware/metrics/metrics_test.go
parent0509f4b4aca9f0e516e641921763e3dd5edead4f (diff)
downloadcoredns-cb867ff6bda5a3964a7ffc767cbeeb0b789259be.tar.gz
coredns-cb867ff6bda5a3964a7ffc767cbeeb0b789259be.tar.zst
coredns-cb867ff6bda5a3964a7ffc767cbeeb0b789259be.zip
middleware/metrics: export ListenAddr (#366)
ListenAddr is the address where the prometheus metric are exported. This can be used in tests to listen on "localhost:0" and then later retrieve the metrics from there. It makes the tests indepent on each other.
Diffstat (limited to 'middleware/metrics/metrics_test.go')
-rw-r--r--middleware/metrics/metrics_test.go4
1 files changed, 2 insertions, 2 deletions
diff --git a/middleware/metrics/metrics_test.go b/middleware/metrics/metrics_test.go
index 4272350f4..f93021fa5 100644
--- a/middleware/metrics/metrics_test.go
+++ b/middleware/metrics/metrics_test.go
@@ -13,7 +13,7 @@ import (
)
func TestMetrics(t *testing.T) {
- met := &Metrics{Addr: Addr, zoneMap: make(map[string]bool)}
+ met := &Metrics{Addr: "localhost:0", zoneMap: make(map[string]bool)}
if err := met.OnStartup(); err != nil {
t.Fatalf("Failed to start metrics handler: %s", err)
}
@@ -71,7 +71,7 @@ func TestMetrics(t *testing.T) {
t.Fatalf("Test %d: Expected no error, but got %s", i, err)
}
- result := mtest.Scrape(t, "http://"+Addr+"/metrics")
+ result := mtest.Scrape(t, "http://"+ListenAddr+"/metrics")
if tc.expectedValue != "" {
got, _ := mtest.MetricValue(tc.metric, result)