diff options
author | 2017-06-13 12:39:10 -0700 | |
---|---|---|
committer | 2017-06-13 12:39:10 -0700 | |
commit | e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae (patch) | |
tree | 152a04673698e1a39caa751c02612d4e21315662 /middleware/pkg/singleflight/singleflight_test.go | |
parent | b1efd3736e6e68ab01baf54f83071c62690899b2 (diff) | |
download | coredns-e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae.tar.gz coredns-e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae.tar.zst coredns-e9eda7e7c8ed75d62b02f23c62e8e318ea1685ae.zip |
New cache implementation and prefetch handing in mw/cache (#731)
* cache: add sharded cache implementation
Add Cache impl and a few tests. This cache is 256-way sharded, mainly
so each shard has it's own lock. The main cache structure is a readonly
jump plane into the right shard.
This should remove the single lock contention on the main lock and
provide more concurrent throughput - Obviously this hasn't been tested
or measured.
The key into the cache was made a uint32 (hash.fnv) and the hashing op
is not using strings.ToLower anymore remove any GC in that code path.
* here too
* Minimum shard size
* typos
* blurp
* small cleanups no defer
* typo
* Add freq based on Johns idea
* cherry-pick conflict resolv
* typo
* update from early code review from john
* add prefetch to the cache
* mw/cache: add prefetch
* remove println
* remove comment
* Fix tests
* Test prefetch in setup
* Add start of cache
* try add diff cache options
* Add hacky testcase
* not needed
* allow the use of a percentage for prefetch
If the TTL falls below xx% do a prefetch, if the record was popular.
Some other fixes and correctly prefetch only popular records.
Diffstat (limited to 'middleware/pkg/singleflight/singleflight_test.go')
-rw-r--r-- | middleware/pkg/singleflight/singleflight_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/middleware/pkg/singleflight/singleflight_test.go b/middleware/pkg/singleflight/singleflight_test.go index 47b4d3dc0..d1d406e0b 100644 --- a/middleware/pkg/singleflight/singleflight_test.go +++ b/middleware/pkg/singleflight/singleflight_test.go @@ -27,7 +27,7 @@ import ( func TestDo(t *testing.T) { var g Group - v, err := g.Do("key", func() (interface{}, error) { + v, err := g.Do(1, func() (interface{}, error) { return "bar", nil }) if got, want := fmt.Sprintf("%v (%T)", v, v), "bar (string)"; got != want { @@ -41,7 +41,7 @@ func TestDo(t *testing.T) { func TestDoErr(t *testing.T) { var g Group someErr := errors.New("Some error") - v, err := g.Do("key", func() (interface{}, error) { + v, err := g.Do(1, func() (interface{}, error) { return nil, someErr }) if err != someErr { @@ -66,7 +66,7 @@ func TestDoDupSuppress(t *testing.T) { for i := 0; i < n; i++ { wg.Add(1) go func() { - v, err := g.Do("key", fn) + v, err := g.Do(1, fn) if err != nil { t.Errorf("Do error: %v", err) } |