aboutsummaryrefslogtreecommitdiff
path: root/middleware/recorder.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2016-04-09 11:13:04 +0100
committerGravatar Miek Gieben <miek@miek.nl> 2016-04-09 11:13:04 +0100
commitdb3d689a8ac2bec199e5643394ffa779341acde0 (patch)
tree01e8a18adb3bb7c2d6bf73b9ab2964452136e97f /middleware/recorder.go
parent16c035731c528f986a93d01b18244cad7d71e725 (diff)
downloadcoredns-db3d689a8ac2bec199e5643394ffa779341acde0.tar.gz
coredns-db3d689a8ac2bec199e5643394ffa779341acde0.tar.zst
coredns-db3d689a8ac2bec199e5643394ffa779341acde0.zip
EDNS: return error on wrong version. (#95)
Split up the previous changes a bit. This PR only returns the expected error when the received packet has the wrong EDNS version. EDNS0 handling in the middleware needs a nicer abstraction, like ReflectEdns() or something.
Diffstat (limited to 'middleware/recorder.go')
-rw-r--r--middleware/recorder.go20
1 files changed, 4 insertions, 16 deletions
diff --git a/middleware/recorder.go b/middleware/recorder.go
index feede34ae..d1e466ec3 100644
--- a/middleware/recorder.go
+++ b/middleware/recorder.go
@@ -1,7 +1,6 @@
package middleware
import (
- "strconv"
"time"
"github.com/miekg/dns"
@@ -54,27 +53,16 @@ func (r *ResponseRecorder) Write(buf []byte) (int, error) {
}
// Size returns the size.
-func (r *ResponseRecorder) Size() int {
- return r.size
-}
+func (r *ResponseRecorder) Size() int { return r.size }
// Rcode returns the rcode.
-func (r *ResponseRecorder) Rcode() string {
- if rcode, ok := dns.RcodeToString[r.rcode]; ok {
- return rcode
- }
- return "RCODE" + strconv.Itoa(r.rcode)
-}
+func (r *ResponseRecorder) Rcode() string { return RcodeToString(r.rcode) }
// Start returns the start time of the ResponseRecorder.
-func (r *ResponseRecorder) Start() time.Time {
- return r.start
-}
+func (r *ResponseRecorder) Start() time.Time { return r.start }
// Msg returns the written message from the ResponseRecorder.
-func (r *ResponseRecorder) Msg() *dns.Msg {
- return r.msg
-}
+func (r *ResponseRecorder) Msg() *dns.Msg { return r.msg }
// Hijack implements dns.Hijacker. It simply wraps the underlying
// ResponseWriter's Hijack method if there is one, or returns an error.