diff options
| author |  Miek Gieben <miek@miek.nl>
| 2020-03-26 09:17:33 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-03-26 09:17:33 +0100 |
| commit | 19cfa2960cc415e0e38d36fc9d9325bd636c000e (patch) | |
| tree | 92862740f97d0378fb0f6dced375fb2d9442271a /plugin/acl | |
| parent | eb23cce1a766ee37cbfc884928f668dac4d0ddff (diff) | |
| download | coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.gz coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.zst coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.zip | |
Cleanup metrics (#3776)
Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.
Signed-off-by: Ben Kochie <superq@gmail.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
Diffstat (limited to 'plugin/acl')
| -rw-r--r-- | plugin/acl/README.md | 4 | ||||
| -rw-r--r-- | plugin/acl/metrics.go | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/plugin/acl/README.md b/plugin/acl/README.md index f96fb12f2..fd08b406b 100644 --- a/plugin/acl/README.md +++ b/plugin/acl/README.md @@ -73,8 +73,8 @@ example.org { If monitoring is enabled (via the _prometheus_ plugin) then the following metrics are exported: -- `coredns_request_block_count_total{server, zone}` - counter of DNS requests being blocked. +- `coredns_dns_blocked_requests_total{server, zone}` - counter of DNS requests being blocked. -- `coredns_request_allow_count_total{server}` - counter of DNS requests being allowed. +- `coredns_dns_allowed_requests_total{server}` - counter of DNS requests being allowed. The `server` and `zone` labels are explained in the _metrics_ plugin documentation. diff --git a/plugin/acl/metrics.go b/plugin/acl/metrics.go index 442ea2374..1f235b85b 100644 --- a/plugin/acl/metrics.go +++ b/plugin/acl/metrics.go @@ -11,14 +11,14 @@ var ( RequestBlockCount = prometheus.NewCounterVec(prometheus.CounterOpts{ Namespace: plugin.Namespace, Subsystem: "dns", - Name: "request_block_count_total", + Name: "acl_blocked_requests_total", Help: "Counter of DNS requests being blocked.", }, []string{"server", "zone"}) // RequestAllowCount is the number of DNS requests being Allowed. RequestAllowCount = prometheus.NewCounterVec(prometheus.CounterOpts{ Namespace: plugin.Namespace, Subsystem: "dns", - Name: "request_allow_count_total", + Name: "acl_allowed_requests_total", Help: "Counter of DNS requests being allowed.", }, []string{"server"}) ) |