diff options
| author |  Petr Menšík <pemensik@redhat.com>
| 2023-07-10 16:49:52 +0200 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2023-07-10 07:49:52 -0700 |
| commit | 52f03483122e87c7a983344af4689536b887f99c (patch) | |
| tree | a25b3dc044eb25e254942356498389a68aee549c /plugin/bufsize/setup_test.go | |
| parent | 7569d132a16dd8778c1f2f7dceeb273a2b8ef115 (diff) | |
| download | coredns-52f03483122e87c7a983344af4689536b887f99c.tar.gz coredns-52f03483122e87c7a983344af4689536b887f99c.tar.zst coredns-52f03483122e87c7a983344af4689536b887f99c.zip | |
Change default value to 1232 (#6183)
* Change default value to 1232
As specified by DNS flag day 2020, good and decent default value
avoiding fragmentation issues should be 1232. It is quite likely 1500
would work reliably on local ethernet networks.
Value 512 is set implicitly and must be used for all clients, which did
not include OPT RR with explicit value they support.
Since MR #5368 it should work correctly.
Signed-off-by: Petr Menšík <pemensik@redhat.com>
* Adapt bufsize test to new default value
Check also buffer size smaller than legacy value is not accepted.
Signed-off-by: Petr Menšík <pemensik@redhat.com>
* Update bufsize documentation
Mention also increasing request size is not possible, it can only reduce
the accepted size.
Signed-off-by: Petr Menšík <pemensik@redhat.com>
---------
Signed-off-by: Petr Menšík <pemensik@redhat.com>
Diffstat (limited to 'plugin/bufsize/setup_test.go')
| -rw-r--r-- | plugin/bufsize/setup_test.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/plugin/bufsize/setup_test.go b/plugin/bufsize/setup_test.go index bb103027d..5bf7b8095 100644 --- a/plugin/bufsize/setup_test.go +++ b/plugin/bufsize/setup_test.go @@ -14,10 +14,11 @@ func TestSetupBufsize(t *testing.T) { expectedData int expectedErrContent string // substring from the expected error. Empty for positive cases. }{ - {`bufsize`, false, 512, ""}, - {`bufsize "1232"`, false, 1232, ""}, + {`bufsize`, false, 1232, ""}, + {`bufsize "1220"`, false, 1220, ""}, {`bufsize "5000"`, true, -1, "plugin"}, {`bufsize "512 512"`, true, -1, "plugin"}, + {`bufsize "511"`, true, -1, "plugin"}, {`bufsize "abc123"`, true, -1, "plugin"}, } |