aboutsummaryrefslogtreecommitdiff
path: root/plugin/cache/cache_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2018-02-17 19:45:52 +0100
committerGravatar GitHub <noreply@github.com> 2018-02-17 19:45:52 +0100
commit8cce06cba10c42ce501a57bd3b7d06ca6064d774 (patch)
tree8b5058915fe0dc06580c1a81a3f795449e17a508 /plugin/cache/cache_test.go
parent9719a47c1bc0bf0098ee07fd004e4d2d2ee139d9 (diff)
downloadcoredns-8cce06cba10c42ce501a57bd3b7d06ca6064d774.tar.gz
coredns-8cce06cba10c42ce501a57bd3b7d06ca6064d774.tar.zst
coredns-8cce06cba10c42ce501a57bd3b7d06ca6064d774.zip
Type.extra (#1538)
* Revert "pkg/typify: empty messages are OtherError (#1531)" This reverts commit fc1d73ffa9ae193c4cfca4adc194ae43f9360dbb. * plugin/cache: add failsafeTTL If we can not see what TTL we should put on a message to be cached, use 5 seconds as minimal TTL. We used to apply the maximum TTL to these messages.
Diffstat (limited to 'plugin/cache/cache_test.go')
-rw-r--r--plugin/cache/cache_test.go11
1 files changed, 0 insertions, 11 deletions
diff --git a/plugin/cache/cache_test.go b/plugin/cache/cache_test.go
index 63b0989b3..b475f3473 100644
--- a/plugin/cache/cache_test.go
+++ b/plugin/cache/cache_test.go
@@ -22,7 +22,6 @@ type cacheTestCase struct {
Authoritative bool
RecursionAvailable bool
Truncated bool
- Response bool
shouldCache bool
}
@@ -113,15 +112,6 @@ var cacheTestCases = []cacheTestCase{
shouldCache: false,
},
{
- // Response with only something in the additional, this should not be cached.
- Response: true,
- in: test.Case{
- Qname: "example.org.", Qtype: dns.TypeMX,
- Extra: []dns.RR{test.MX("example.org. 1800 IN MX 1 mx.example.org.")},
- },
- shouldCache: false,
- },
- {
RecursionAvailable: true, Authoritative: true,
Case: test.Case{
Qname: "example.org.", Qtype: dns.TypeMX,
@@ -150,7 +140,6 @@ func cacheMsg(m *dns.Msg, tc cacheTestCase) *dns.Msg {
m.AuthenticatedData = tc.AuthenticatedData
m.Authoritative = tc.Authoritative
m.Rcode = tc.Rcode
- m.Response = tc.Response
m.Truncated = tc.Truncated
m.Answer = tc.in.Answer
m.Ns = tc.in.Ns