diff options
| author |  Miek Gieben <miek@miek.nl>
| 2019-10-01 07:41:29 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2019-10-01 07:41:29 +0100 |
| commit | dbd1c047cb973fc669fbe4e97dc12e7b3d3e6ed8 (patch) | |
| tree | 4737fb65ef07bdfd3e24e2c76a147edde5db852c /plugin/dnssec/dnssec_test.go | |
| parent | 55a01dadaacc33674aff1e936b101695f9de32cf (diff) | |
| download | coredns-dbd1c047cb973fc669fbe4e97dc12e7b3d3e6ed8.tar.gz coredns-dbd1c047cb973fc669fbe4e97dc12e7b3d3e6ed8.tar.zst coredns-dbd1c047cb973fc669fbe4e97dc12e7b3d3e6ed8.zip | |
Run gostaticheck (#3325)
* Run gostaticheck
Run gostaticcheck on the codebase and fix almost all flagged items.
Only keep
* coremain/run.go:192:2: var appVersion is unused (U1000)
* plugin/chaos/setup.go:54:3: the surrounding loop is unconditionally terminated (SA4004)
* plugin/etcd/setup.go:103:3: the surrounding loop is unconditionally terminated (SA4004)
* plugin/pkg/replacer/replacer.go:274:13: argument should be pointer-like to avoid allocations (SA6002)
* plugin/route53/setup.go:124:28: session.New is deprecated: Use NewSession functions to create sessions instead. NewSession has the same functionality as New except an error can be returned when the func is called instead of waiting to receive an error until a request is made. (SA1019)
* test/grpc_test.go:25:69: grpc.WithTimeout is deprecated: use DialContext and context.WithTimeout instead. Will be supported throughout 1.x. (SA1019)
The first one isn't true, as this is set via ldflags. The rest is
minor. The deprecation should be fixed at some point; I'll file some
issues.
Signed-off-by: Miek Gieben <miek@miek.nl>
* Make sure to plug in the plugins
import the plugins, that file that did this was removed, put it in the
reload test as this requires an almost complete coredns server.
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/dnssec/dnssec_test.go')
| -rw-r--r-- | plugin/dnssec/dnssec_test.go | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/plugin/dnssec/dnssec_test.go b/plugin/dnssec/dnssec_test.go index e60b5ee7e..fb8a128de 100644 --- a/plugin/dnssec/dnssec_test.go +++ b/plugin/dnssec/dnssec_test.go @@ -153,20 +153,6 @@ func testMsgCname() *dns.Msg { } } -func testDelegationMsg() *dns.Msg { - return &dns.Msg{ - Ns: []dns.RR{ - test.NS("miek.nl. 3600 IN NS linode.atoom.net."), - test.NS("miek.nl. 3600 IN NS ns-ext.nlnetlabs.nl."), - test.NS("miek.nl. 3600 IN NS omval.tednet.nl."), - }, - Extra: []dns.RR{ - test.A("omval.tednet.nl. 3600 IN A 185.49.141.42"), - test.AAAA("omval.tednet.nl. 3600 IN AAAA 2a04:b900:0:100::42"), - }, - } -} - func testMsgDname() *dns.Msg { return &dns.Msg{ Answer: []dns.RR{ |