diff options
author | 2018-06-02 19:48:39 +0100 | |
---|---|---|
committer | 2018-06-02 11:48:39 -0700 | |
commit | 22c0b30d5f7468c2477291419bee3e88dfba490c (patch) | |
tree | 1454e8de2c457fcc649a7712815a6a980526ee6b /plugin/dnssec/handler_test.go | |
parent | 3994d3a5a704aab10aa0e52fac8d60ac872ecaad (diff) | |
download | coredns-22c0b30d5f7468c2477291419bee3e88dfba490c.tar.gz coredns-22c0b30d5f7468c2477291419bee3e88dfba490c.tar.zst coredns-22c0b30d5f7468c2477291419bee3e88dfba490c.zip |
presubmit: Check errorf as well (#1845)
Uppercase all these test errors as well. And extend the presubmit to
check for these in the future. Also do a slightly smarter grep to only
get t.<something>. as (because dump regexp) this also grep over non test
files.
Diffstat (limited to 'plugin/dnssec/handler_test.go')
-rw-r--r-- | plugin/dnssec/handler_test.go | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/plugin/dnssec/handler_test.go b/plugin/dnssec/handler_test.go index d2d566af9..a1c35c635 100644 --- a/plugin/dnssec/handler_test.go +++ b/plugin/dnssec/handler_test.go @@ -118,7 +118,7 @@ func TestLookupZone(t *testing.T) { rec := dnstest.NewRecorder(&test.ResponseWriter{}) _, err := dh.ServeDNS(ctx, rec, m) if err != nil { - t.Errorf("expected no error, got %v\n", err) + t.Errorf("Expected no error, got %v\n", err) return } @@ -141,7 +141,7 @@ func TestLookupDNSKEY(t *testing.T) { rec := dnstest.NewRecorder(&test.ResponseWriter{}) _, err := dh.ServeDNS(ctx, rec, m) if err != nil { - t.Errorf("expected no error, got %v\n", err) + t.Errorf("Expected no error, got %v\n", err) return } @@ -157,7 +157,7 @@ func TestLookupDNSKEY(t *testing.T) { if n, ok := rr.(*dns.NSEC); ok { for i := range n.TypeBitMap { if n.TypeBitMap[i] == tc.Qtype { - t.Errorf("bitmap contains qtype: %d", tc.Qtype) + t.Errorf("Bitmap contains qtype: %d", tc.Qtype) } } } |