diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-12-06 21:18:11 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-12-06 21:18:11 +0000 |
| commit | fc667b98e0587dcebe19183b83f99059513dba0e (patch) | |
| tree | fe45c8a3659458427d2114c4767308b362a807af /plugin/dnssec/handler_test.go | |
| parent | f51c110511c13b80c7d7234c3d56dbefa79705a2 (diff) | |
| download | coredns-fc667b98e0587dcebe19183b83f99059513dba0e.tar.gz coredns-fc667b98e0587dcebe19183b83f99059513dba0e.tar.zst coredns-fc667b98e0587dcebe19183b83f99059513dba0e.zip | |
Fix EDNS0 compliance (#2357)
* Fix EDNS0 compliance
Do SizeAndDo in the server (ScrubWriter) and remove all uses of this
from the plugins. Also *always* do it. This is to get into compliance
for https://dnsflagday.net/.
The pkg/edns0 now exports the EDNS0 options we understand; this is
exported to allow plugins add things there. The *rewrite* plugin used
this to add custom EDNS0 option codes that the server needs to
understand.
This also needs a new release of miekg/dns because it triggered a
race-condition that was basicly there forever.
See:
* https://github.com/miekg/dns/issues/857
* https://github.com/miekg/dns/pull/859
Running a test instance and pointing the https://ednscomp.isc.org/ednscomp
to it shows the tests are now fixed:
~~~
EDNS Compliance Tester
Checking: 'miek.nl' as at 2018-12-01T17:53:15Z
miek.nl. @147.75.204.203 (drone.coredns.io.): dns=ok edns=ok edns1=ok edns@512=ok ednsopt=ok edns1opt=ok do=ok ednsflags=ok docookie=ok edns512tcp=ok optlist=ok
miek.nl. @2604:1380:2002:a000::1 (drone.coredns.io.): dns=ok edns=ok edns1=ok edns@512=ok ednsopt=ok edns1opt=ok do=ok ednsflags=ok docookie=ok edns512tcp=ok optlist=ok
All Ok
Codes
ok - test passed.
~~~
Signed-off-by: Miek Gieben <miek@miek.nl>
Signed-off-by: Miek Gieben <miek@miek.nl>
* typos in comments
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/dnssec/handler_test.go')
| -rw-r--r-- | plugin/dnssec/handler_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugin/dnssec/handler_test.go b/plugin/dnssec/handler_test.go index 35444eecb..8e997bca8 100644 --- a/plugin/dnssec/handler_test.go +++ b/plugin/dnssec/handler_test.go @@ -26,7 +26,7 @@ var dnssecTestCases = []test.Case{ test.DNSKEY("miek.nl. 3600 IN DNSKEY 257 3 13 0J8u0XJ9GNGFEBXuAmLu04taHG4"), test.RRSIG("miek.nl. 3600 IN RRSIG DNSKEY 13 2 3600 20160503150844 20160425120844 18512 miek.nl. Iw/kNOyM"), }, - Extra: []dns.RR{test.OPT(4096, true)}, + /* Extra: []dns.RR{test.OPT(4096, true)}, this has moved to the server and can't be test here */ }, } |