diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-05-07 22:47:25 +0100 |
|---|---|---|
| committer |  Yong Tang <yong.tang.github@outlook.com>
| 2018-05-07 23:47:25 +0200 |
| commit | 643550eabe37176fd27c8aa9263c8c4206be066d (patch) | |
| tree | 6dd27292218b96176e3fd314d7251f98e41802f3 /plugin/dnstap/handler_test.go | |
| parent | 15d989e294dbfd29bb3e8083190f1bc68bcd170c (diff) | |
| download | coredns-643550eabe37176fd27c8aa9263c8c4206be066d.tar.gz coredns-643550eabe37176fd27c8aa9263c8c4206be066d.tar.zst coredns-643550eabe37176fd27c8aa9263c8c4206be066d.zip | |
presubmit: check for uppercase (#1774)
Another thing we can test automatically, we sorta settled on using an
uppercase letter in in t.Log and t.Fatal calls.
Let's just check for this.
Diffstat (limited to 'plugin/dnstap/handler_test.go')
| -rw-r--r-- | plugin/dnstap/handler_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/plugin/dnstap/handler_test.go b/plugin/dnstap/handler_test.go index 003a385c8..01dbb873a 100644 --- a/plugin/dnstap/handler_test.go +++ b/plugin/dnstap/handler_test.go @@ -103,7 +103,7 @@ func TestError(t *testing.T) { // the dnstap error will show only if there is no plugin error _, err := h.ServeDNS(context.TODO(), rw, nil) if err == nil || !strings.HasPrefix(err.Error(), "plugin/dnstap") { - t.Fatal("must return the dnstap error but have:", err) + t.Fatal("Must return the dnstap error but have:", err) } // plugin errors will always overwrite dnstap errors @@ -111,6 +111,6 @@ func TestError(t *testing.T) { h.Next = endWith(0, pluginErr) _, err = h.ServeDNS(context.TODO(), rw, nil) if err != pluginErr { - t.Fatal("must return the plugin error but have:", err) + t.Fatal("Must return the plugin error but have:", err) } } |