aboutsummaryrefslogtreecommitdiff
path: root/plugin/file/delegation_test.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2020-05-11 16:51:02 +0200
committerGravatar GitHub <noreply@github.com> 2020-05-11 07:51:02 -0700
commit7aaed71b92cbdddfbc13ddc6ce618bb083502c42 (patch)
tree43c325298c2b3a5f54b61d7dbddd54a98dd6ace1 /plugin/file/delegation_test.go
parent886cdd9dd361310e1e99861ece5bcac1a59f8367 (diff)
downloadcoredns-7aaed71b92cbdddfbc13ddc6ce618bb083502c42.tar.gz
coredns-7aaed71b92cbdddfbc13ddc6ce618bb083502c42.tar.zst
coredns-7aaed71b92cbdddfbc13ddc6ce618bb083502c42.zip
Fix query for SOA record for delegated zone (#3875)
Addresses a bug in the file plugin where SOA queries to zone delegations are inappropriately returned the SOA for the delegating zone, and not a downward referral to the delegated zone. Here is an example of what I believe the expected downward referral in response to a SOA query for a delegated zone should be (note that no SOA record is returned): ~~~ ; <<>> DiG 9.11.3-1ubuntu1.5-Ubuntu <<>> @k.root-servers.net. miek.nl. SOA ; (2 servers found) ;; global options: +cmd ;; Got answer: ;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 58381 ;; flags: qr rd; QUERY: 1, ANSWER: 0, AUTHORITY: 3, ADDITIONAL: 7 ;; WARNING: recursion requested but not available ;; OPT PSEUDOSECTION: ; EDNS: version: 0, flags:; udp: 4096 ;; QUESTION SECTION: ;miek.nl. IN SOA ;; AUTHORITY SECTION: nl. 172800 IN NS ns1.dns.nl. nl. 172800 IN NS ns2.dns.nl. nl. 172800 IN NS ns3.dns.nl. ;; ADDITIONAL SECTION: ns1.dns.nl. 172800 IN A 194.0.28.53 ns2.dns.nl. 172800 IN A 194.146.106.42 ns3.dns.nl. 172800 IN A 194.0.25.24 ns1.dns.nl. 172800 IN AAAA 2001:678:2c:0:194:0:28:53 ns2.dns.nl. 172800 IN AAAA 2001:67c:1010:10::53 ns3.dns.nl. 172800 IN AAAA 2001:678:20::24 ~~~ See #3852 for the original fix. Modified clouddns/route53 and removed the faulty tests there. Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/file/delegation_test.go')
-rw-r--r--plugin/file/delegation_test.go11
1 files changed, 11 insertions, 0 deletions
diff --git a/plugin/file/delegation_test.go b/plugin/file/delegation_test.go
index a317b827b..a6da6215c 100644
--- a/plugin/file/delegation_test.go
+++ b/plugin/file/delegation_test.go
@@ -57,6 +57,17 @@ var delegationTestCases = []test.Case{
},
},
{
+ Qname: "foo.delegated.miek.nl.", Qtype: dns.TypeSOA,
+ Ns: []dns.RR{
+ test.NS("delegated.miek.nl. 1800 IN NS a.delegated.miek.nl."),
+ test.NS("delegated.miek.nl. 1800 IN NS ns-ext.nlnetlabs.nl."),
+ },
+ Extra: []dns.RR{
+ test.A("a.delegated.miek.nl. 1800 IN A 139.162.196.78"),
+ test.AAAA("a.delegated.miek.nl. 1800 IN AAAA 2a01:7e00::f03c:91ff:fef1:6735"),
+ },
+ },
+ {
Qname: "miek.nl.", Qtype: dns.TypeSOA,
Answer: []dns.RR{
test.SOA("miek.nl. 1800 IN SOA linode.atoom.net. miek.miek.nl. 1282630057 14400 3600 604800 14400"),