diff options
author | 2019-01-19 11:23:13 +0000 | |
---|---|---|
committer | 2019-01-19 11:23:13 +0000 | |
commit | 725becd134752caead1aa2b2cf3a72d01c13b599 (patch) | |
tree | 300dbfeac60f6cffd86c3aeb0b68d772415e6521 /plugin/file/ds_test.go | |
parent | 278303ca0df6e6167788fa3435f6ea7c6253157b (diff) | |
download | coredns-725becd134752caead1aa2b2cf3a72d01c13b599.tar.gz coredns-725becd134752caead1aa2b2cf3a72d01c13b599.tar.zst coredns-725becd134752caead1aa2b2cf3a72d01c13b599.zip |
Stop importing testing in the main binary (#2479)
* Stop importing testing in the main binary
Stop importing "testing" into the main binary:
* test/helpers.go imported it; remote that and change function signature
* update all tests that use this
Signed-off-by: Miek Gieben <miek@miek.nl>
* Drop import testing from metrics plugin
Signed-off-by: Miek Gieben <miek@miek.nl>
* more fiddling
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/file/ds_test.go')
-rw-r--r-- | plugin/file/ds_test.go | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/plugin/file/ds_test.go b/plugin/file/ds_test.go index 5e4ed7e4c..74f7bbd2b 100644 --- a/plugin/file/ds_test.go +++ b/plugin/file/ds_test.go @@ -65,11 +65,13 @@ func TestLookupDS(t *testing.T) { rec := dnstest.NewRecorder(&test.ResponseWriter{}) _, err := fm.ServeDNS(ctx, rec, m) if err != nil { - t.Errorf("Expected no error, got %v\n", err) + t.Errorf("Expected no error, got %v", err) return } resp := rec.Msg - test.SortAndCheck(t, resp, tc) + if err := test.SortAndCheck(resp, tc); err != nil { + t.Error(err) + } } } |