diff options
| author |  Miek Gieben <miek@miek.nl>
| 2021-03-09 21:17:34 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2021-03-09 12:17:34 -0800 |
| commit | 74ef6e00f189e6590185d0625d8cc0767511de46 (patch) | |
| tree | 3bdc1b942707131fbf0db094cfccea1a6ba0bfbe /plugin/file/file.go | |
| parent | c27605797b3f0aec5d34d15b0e08b76b11b92c11 (diff) | |
| download | coredns-74ef6e00f189e6590185d0625d8cc0767511de46.tar.gz coredns-74ef6e00f189e6590185d0625d8cc0767511de46.tar.zst coredns-74ef6e00f189e6590185d0625d8cc0767511de46.zip | |
transfer: reply with refused (#4510)
* transfer: reply with refused
When the *transfer* plugin is not loaded and of the handlers will still
see the AXFR/IXFR request because it is not intercepted.
They need to reply with REFUSED in that case. Update file, auto and k8s
to do this. Add testcase in the file plugin.
Ideally *erratic* should be moved over as well, but maybe that's
*erratic*
This is a bug fix.
Signed-off-by: Miek Gieben <miek@miek.nl>
* import path
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/file/file.go')
| -rw-r--r-- | plugin/file/file.go | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/plugin/file/file.go b/plugin/file/file.go index 1c586dd6d..0834ddc4d 100644 --- a/plugin/file/file.go +++ b/plugin/file/file.go @@ -47,6 +47,11 @@ func (f File) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (i return dns.RcodeServerFailure, nil } + // If transfer is not loaded, we'll see these, answer with refused (no transfer allowed). + if state.QType() == dns.TypeAXFR || state.QType() == dns.TypeIXFR { + return dns.RcodeRefused, nil + } + // This is only for when we are a secondary zones. if r.Opcode == dns.OpcodeNotify { if z.isNotify(state) { |