diff options
| author |  Miek Gieben <miek@miek.nl>
| 2019-08-01 12:51:37 +0000 |
|---|---|---|
| committer |  Yong Tang <yong.tang.github@outlook.com>
| 2019-08-01 05:51:37 -0700 |
| commit | a01b202b6ace52148dcfdfe8bc723878e0f911f8 (patch) | |
| tree | c885cccb1756301238543eeb1bfd046db2d2902a /plugin/file/file.go | |
| parent | 3219a2b93a8010af9b5c2263c658815a4494416e (diff) | |
| download | coredns-a01b202b6ace52148dcfdfe8bc723878e0f911f8.tar.gz coredns-a01b202b6ace52148dcfdfe8bc723878e0f911f8.tar.zst coredns-a01b202b6ace52148dcfdfe8bc723878e0f911f8.zip | |
Fixes races in test and klog (#3079)
Various fixes to make things less flaky:
* kubernetes: put klog.SetOutput in the setup function, not in the init
function to see if that helps
* file: make z.Expired a boolean instead of a pointer to a boolean
* test: fix TestSecondaryZoneTransfer test, which wasn't actually
testing in the right way. It's more right now, but may still be racy
(race introduced because a file's lazy loading of zones)
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/file/file.go')
| -rw-r--r-- | plugin/file/file.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/plugin/file/file.go b/plugin/file/file.go index 8e10499fa..1aebf6cda 100644 --- a/plugin/file/file.go +++ b/plugin/file/file.go @@ -72,7 +72,7 @@ func (f File) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (i z.RLock() exp := z.Expired z.RUnlock() - if exp != nil && *exp { + if exp { log.Errorf("Zone %s is expired", zone) return dns.RcodeServerFailure, nil } |