diff options
| author |  Yong Tang <yong.tang.github@outlook.com>
| 2020-09-24 11:30:39 -0700 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-09-24 20:30:39 +0200 |
| commit | 9798dd067f53a74e3777cff539b2f01617c107c6 (patch) | |
| tree | fac3bbc495c9a7f78fd9a847fb44533bd6367d9a /plugin/file/reload.go | |
| parent | 279194f2e45c9dfeccafe95e515e0aced0ea8bdc (diff) | |
| download | coredns-9798dd067f53a74e3777cff539b2f01617c107c6.tar.gz coredns-9798dd067f53a74e3777cff539b2f01617c107c6.tar.zst coredns-9798dd067f53a74e3777cff539b2f01617c107c6.zip | |
Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142)
* Implement notifies for transfer plugin (#3972)
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl>
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl>
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl>
* golint
Signed-off-by: Miek Gieben <miek@miek.nl>
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl>
* Fix notifies in transfer plugin
Signed-off-by: Miek Gieben <miek@miek.nl>
* Make it compile
Signed-off-by: Miek Gieben <miek@miek.nl>
* Port more plugins
Signed-off-by: Miek Gieben <miek@miek.nl>
* golint
Signed-off-by: Miek Gieben <miek@miek.nl>
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl>
* Fix tests
Signed-off-by: Miek Gieben <miek@miek.nl>
* really fix test
Signed-off-by: Miek Gieben <miek@miek.nl>
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl>
* Add transfer tests
copied and modified from #3452
Signed-off-by: Miek Gieben <miek@miek.nl>
* Test correct selection of plugin
Signed-off-by: Miek Gieben <miek@miek.nl>
* add upstream back in
Signed-off-by: Miek Gieben <miek@miek.nl>
* Implement ixfr fallback and unify file and auto for transfering
Signed-off-by: Miek Gieben <miek@miek.nl>
* fix test
Signed-off-by: Miek Gieben <miek@miek.nl>
* properly merge
Signed-off-by: Miek Gieben <miek@miek.nl>
* Remove plugin/kubernetes/setup_transfer_test.go
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Co-authored-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/file/reload.go')
| -rw-r--r-- | plugin/file/reload.go | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/plugin/file/reload.go b/plugin/file/reload.go index 79db040fe..426a986b0 100644 --- a/plugin/file/reload.go +++ b/plugin/file/reload.go @@ -3,10 +3,12 @@ package file import ( "os" "time" + + "github.com/coredns/coredns/plugin/transfer" ) // Reload reloads a zone when it is changed on disk. If z.NoReload is true, no reloading will be done. -func (z *Zone) Reload() error { +func (z *Zone) Reload(t *transfer.Transfer) error { if z.ReloadInterval == 0 { return nil } @@ -40,7 +42,11 @@ func (z *Zone) Reload() error { z.Unlock() log.Infof("Successfully reloaded zone %q in %q with %d SOA serial", z.origin, zFile, z.Apex.SOA.Serial) - z.Notify() + if t != nil { + if err := t.Notify(z.origin); err != nil { + log.Warningf("Failed sending notifies: %s", err) + } + } case <-z.reloadShutdown: tick.Stop() |