diff options
author | 2018-05-07 22:47:25 +0100 | |
---|---|---|
committer | 2018-05-07 23:47:25 +0200 | |
commit | 643550eabe37176fd27c8aa9263c8c4206be066d (patch) | |
tree | 6dd27292218b96176e3fd314d7251f98e41802f3 /plugin/file/reload_test.go | |
parent | 15d989e294dbfd29bb3e8083190f1bc68bcd170c (diff) | |
download | coredns-643550eabe37176fd27c8aa9263c8c4206be066d.tar.gz coredns-643550eabe37176fd27c8aa9263c8c4206be066d.tar.zst coredns-643550eabe37176fd27c8aa9263c8c4206be066d.zip |
presubmit: check for uppercase (#1774)
Another thing we can test automatically, we sorta settled on using an
uppercase letter in in t.Log and t.Fatal calls.
Let's just check for this.
Diffstat (limited to 'plugin/file/reload_test.go')
-rw-r--r-- | plugin/file/reload_test.go | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/plugin/file/reload_test.go b/plugin/file/reload_test.go index 924889fa5..e98153662 100644 --- a/plugin/file/reload_test.go +++ b/plugin/file/reload_test.go @@ -16,16 +16,16 @@ import ( func TestZoneReload(t *testing.T) { fileName, rm, err := test.TempFile(".", reloadZoneTest) if err != nil { - t.Fatalf("failed to create zone: %s", err) + t.Fatalf("Failed to create zone: %s", err) } defer rm() reader, err := os.Open(fileName) if err != nil { - t.Fatalf("failed to open zone: %s", err) + t.Fatalf("Failed to open zone: %s", err) } z, err := Parse(reader, "miek.nl", fileName, 0) if err != nil { - t.Fatalf("failed to parse zone: %s", err) + t.Fatalf("Failed to parse zone: %s", err) } TickTime = 500 * time.Millisecond @@ -36,34 +36,34 @@ func TestZoneReload(t *testing.T) { r.SetQuestion("miek.nl", dns.TypeSOA) state := request.Request{W: &test.ResponseWriter{}, Req: r} if _, _, _, res := z.Lookup(state, "miek.nl."); res != Success { - t.Fatalf("failed to lookup, got %d", res) + t.Fatalf("Failed to lookup, got %d", res) } r = new(dns.Msg) r.SetQuestion("miek.nl", dns.TypeNS) state = request.Request{W: &test.ResponseWriter{}, Req: r} if _, _, _, res := z.Lookup(state, "miek.nl."); res != Success { - t.Fatalf("failed to lookup, got %d", res) + t.Fatalf("Failed to lookup, got %d", res) } if len(z.All()) != 5 { - t.Fatalf("expected 5 RRs, got %d", len(z.All())) + t.Fatalf("Expected 5 RRs, got %d", len(z.All())) } if err := ioutil.WriteFile(fileName, []byte(reloadZone2Test), 0644); err != nil { - t.Fatalf("failed to write new zone data: %s", err) + t.Fatalf("Failed to write new zone data: %s", err) } // Could still be racy, but we need to wait a bit for the event to be seen time.Sleep(1 * time.Second) if len(z.All()) != 3 { - t.Fatalf("expected 3 RRs, got %d", len(z.All())) + t.Fatalf("Expected 3 RRs, got %d", len(z.All())) } } func TestZoneReloadSOAChange(t *testing.T) { _, err := Parse(strings.NewReader(reloadZoneTest), "miek.nl.", "stdin", 1460175181) if err == nil { - t.Fatalf("zone should not have been re-parsed") + t.Fatalf("Zone should not have been re-parsed") } } |