diff options
| author |  Miek Gieben <miek@miek.nl>
| 2020-03-26 09:17:33 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-03-26 09:17:33 +0100 |
| commit | 19cfa2960cc415e0e38d36fc9d9325bd636c000e (patch) | |
| tree | 92862740f97d0378fb0f6dced375fb2d9442271a /plugin/forward/metrics.go | |
| parent | eb23cce1a766ee37cbfc884928f668dac4d0ddff (diff) | |
| download | coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.gz coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.zst coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.zip | |
Cleanup metrics (#3776)
Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.
Signed-off-by: Ben Kochie <superq@gmail.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
Diffstat (limited to 'plugin/forward/metrics.go')
| -rw-r--r-- | plugin/forward/metrics.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/plugin/forward/metrics.go b/plugin/forward/metrics.go index d92028d24..4122bc210 100644 --- a/plugin/forward/metrics.go +++ b/plugin/forward/metrics.go @@ -11,13 +11,13 @@ var ( RequestCount = prometheus.NewCounterVec(prometheus.CounterOpts{ Namespace: plugin.Namespace, Subsystem: "forward", - Name: "request_count_total", + Name: "requests_total", Help: "Counter of requests made per upstream.", }, []string{"to"}) RcodeCount = prometheus.NewCounterVec(prometheus.CounterOpts{ Namespace: plugin.Namespace, Subsystem: "forward", - Name: "response_rcode_count_total", + Name: "responses_total", Help: "Counter of requests made per upstream.", }, []string{"rcode", "to"}) RequestDuration = prometheus.NewHistogramVec(prometheus.HistogramOpts{ @@ -30,13 +30,13 @@ var ( HealthcheckFailureCount = prometheus.NewCounterVec(prometheus.CounterOpts{ Namespace: plugin.Namespace, Subsystem: "forward", - Name: "healthcheck_failure_count_total", + Name: "healthcheck_failures_total", Help: "Counter of the number of failed healthchecks.", }, []string{"to"}) HealthcheckBrokenCount = prometheus.NewCounter(prometheus.CounterOpts{ Namespace: plugin.Namespace, Subsystem: "forward", - Name: "healthcheck_broken_count_total", + Name: "healthcheck_broken_total", Help: "Counter of the number of complete failures of the healthchecks.", }) SocketGauge = prometheus.NewGaugeVec(prometheus.GaugeOpts{ @@ -48,7 +48,7 @@ var ( MaxConcurrentRejectCount = prometheus.NewCounter(prometheus.CounterOpts{ Namespace: plugin.Namespace, Subsystem: "forward", - Name: "max_concurrent_reject_count_total", + Name: "max_concurrent_rejects_total", Help: "Counter of the number of queries rejected because the concurrent queries were at maximum.", }) ) |