diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-04-24 18:18:26 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-04-24 18:18:26 +0100 |
| commit | ce084012df435a98cac5511a294a0c45a1a3abf9 (patch) | |
| tree | 122e18eb6623ff6841e33f544042881e49895cd3 /plugin/forward/setup_test.go | |
| parent | f529a2771ff9d1be38d2200c0e02382600b499f1 (diff) | |
| download | coredns-ce084012df435a98cac5511a294a0c45a1a3abf9.tar.gz coredns-ce084012df435a98cac5511a294a0c45a1a3abf9.tar.zst coredns-ce084012df435a98cac5511a294a0c45a1a3abf9.zip | |
plugin/forward: fix TLS setup (#1714)
* plugin/forward: fix TLS setup
Way smaller PR than #1679. Fixes same thing.
* remove println
* put overwritten test back
* context
* update tests
Diffstat (limited to 'plugin/forward/setup_test.go')
| -rw-r--r-- | plugin/forward/setup_test.go | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/plugin/forward/setup_test.go b/plugin/forward/setup_test.go index d787a59d0..fba2359b9 100644 --- a/plugin/forward/setup_test.go +++ b/plugin/forward/setup_test.go @@ -77,9 +77,16 @@ func TestSetupTLS(t *testing.T) { expectedErr string }{ // positive + {`forward . tls://127.0.0.1 { + tls_servername dns + }`, false, "dns", ""}, {`forward . 127.0.0.1 { - tls_servername dns - }`, false, "dns", ""}, + tls_servername dns + }`, false, "", ""}, + {`forward . 127.0.0.1 { + tls + }`, false, "", ""}, + {`forward . tls://127.0.0.1`, false, "", ""}, } for i, test := range tests { @@ -100,8 +107,12 @@ func TestSetupTLS(t *testing.T) { } } - if !test.shouldErr && test.expectedServerName != f.tlsConfig.ServerName { + if !test.shouldErr && test.expectedServerName != "" && test.expectedServerName != f.tlsConfig.ServerName { t.Errorf("Test %d: expected: %q, actual: %q", i, test.expectedServerName, f.tlsConfig.ServerName) } + + if !test.shouldErr && test.expectedServerName != "" && test.expectedServerName != f.proxies[0].client.TLSConfig.ServerName { + t.Errorf("Test %d: expected: %q, actual: %q", i, test.expectedServerName, f.proxies[0].client.TLSConfig.ServerName) + } } } |