aboutsummaryrefslogtreecommitdiff
path: root/plugin/kubernetes/handler.go
diff options
context:
space:
mode:
authorGravatar Chris O'Haver <cohaver@infoblox.com> 2021-05-04 05:05:08 -0400
committerGravatar GitHub <noreply@github.com> 2021-05-04 11:05:08 +0200
commitd6d8a9974bc45855a7d8a89e9e452cc9b6301d0e (patch)
treea9ef99d81c9606886ae4d54c908c2ca927fd30ec /plugin/kubernetes/handler.go
parente1931d48d152696f53e9890d8fa99b5471a91158 (diff)
downloadcoredns-d6d8a9974bc45855a7d8a89e9e452cc9b6301d0e.tar.gz
coredns-d6d8a9974bc45855a7d8a89e9e452cc9b6301d0e.tar.zst
coredns-d6d8a9974bc45855a7d8a89e9e452cc9b6301d0e.zip
plugin/kubernetes: fix SOA response for non-apex queries (#4592)
* fix SOA response for non-apex queries Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * handle mixed case Signed-off-by: Chris O'Haver <cohaver@infoblox.com> * do full string compare Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
Diffstat (limited to 'plugin/kubernetes/handler.go')
-rw-r--r--plugin/kubernetes/handler.go5
1 files changed, 3 insertions, 2 deletions
diff --git a/plugin/kubernetes/handler.go b/plugin/kubernetes/handler.go
index 0bf4b12af..336fd08db 100644
--- a/plugin/kubernetes/handler.go
+++ b/plugin/kubernetes/handler.go
@@ -43,7 +43,9 @@ func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.M
case dns.TypeSRV:
records, extra, err = plugin.SRV(ctx, &k, zone, state, plugin.Options{})
case dns.TypeSOA:
- records, err = plugin.SOA(ctx, &k, zone, state, plugin.Options{})
+ if qname == zone {
+ records, err = plugin.SOA(ctx, &k, zone, state, plugin.Options{})
+ }
case dns.TypeAXFR, dns.TypeIXFR:
return dns.RcodeRefused, nil
case dns.TypeNS:
@@ -82,7 +84,6 @@ func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.M
m.Authoritative = true
m.Answer = append(m.Answer, records...)
m.Extra = append(m.Extra, extra...)
-
w.WriteMsg(m)
return dns.RcodeSuccess, nil
}