diff options
| author |  Miek Gieben <miek@miek.nl>
| 2017-11-13 21:51:51 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2017-11-13 21:51:51 +0000 |
| commit | c37bf56b1e30ebc9bc94efca0ea12158d5648463 (patch) | |
| tree | a245ff90b070b8d4b8da9f492c701e6f367b3e1d /plugin/kubernetes/handler_pod_verified_test.go | |
| parent | 9018451dd30caf40f4c7e5e6e5d614c31b2f42e6 (diff) | |
| download | coredns-c37bf56b1e30ebc9bc94efca0ea12158d5648463.tar.gz coredns-c37bf56b1e30ebc9bc94efca0ea12158d5648463.tar.zst coredns-c37bf56b1e30ebc9bc94efca0ea12158d5648463.zip | |
plugin/kubernetes: correctly set NODATA for ns (#1229)
* plugin/kubernetes: Add GetNamespaceByName
A bare or wildcard query for just the namespace should return NODATA,
not NXDOMAIN, otherwise we deny the entirety of the names under the
namespace.
Add test to check for this in pod verified mode.
* Review
More comments and move namespace code to namespace.go
Diffstat (limited to 'plugin/kubernetes/handler_pod_verified_test.go')
| -rw-r--r-- | plugin/kubernetes/handler_pod_verified_test.go | 21 |
1 files changed, 21 insertions, 0 deletions
diff --git a/plugin/kubernetes/handler_pod_verified_test.go b/plugin/kubernetes/handler_pod_verified_test.go index 35aa92c05..e2c488e5e 100644 --- a/plugin/kubernetes/handler_pod_verified_test.go +++ b/plugin/kubernetes/handler_pod_verified_test.go @@ -19,6 +19,27 @@ var podModeVerifiedCases = []test.Case{ }, }, { + Qname: "podns.pod.cluster.local.", Qtype: dns.TypeA, + Rcode: dns.RcodeSuccess, + Ns: []dns.RR{ + test.SOA("cluster.local. 300 IN SOA ns.dns.cluster.local. hostmaster.cluster.local. 1499347823 7200 1800 86400 60"), + }, + }, + { + Qname: "svcns.svc.cluster.local.", Qtype: dns.TypeA, + Rcode: dns.RcodeSuccess, + Ns: []dns.RR{ + test.SOA("cluster.local. 300 IN SOA ns.dns.cluster.local. hostmaster.cluster.local. 1499347823 7200 1800 86400 60"), + }, + }, + { + Qname: "pod-nons.pod.cluster.local.", Qtype: dns.TypeA, + Rcode: dns.RcodeNameError, + Ns: []dns.RR{ + test.SOA("cluster.local. 300 IN SOA ns.dns.cluster.local. hostmaster.cluster.local. 1499347823 7200 1800 86400 60"), + }, + }, + { Qname: "172-0-0-2.podns.pod.cluster.local.", Qtype: dns.TypeA, Rcode: dns.RcodeNameError, Ns: []dns.RR{ |