aboutsummaryrefslogtreecommitdiff
path: root/plugin/kubernetes/kubernetes.go
diff options
context:
space:
mode:
authorGravatar Miek Gieben <miek@miek.nl> 2018-01-06 15:56:54 +0000
committerGravatar GitHub <noreply@github.com> 2018-01-06 15:56:54 +0000
commit75a8a17da4fc95c086dfb447d29c02e7dbd05561 (patch)
treeb6277f3344a0bbbd00f1a4b33c3aa2480b0c75dc /plugin/kubernetes/kubernetes.go
parenta8e268e33b35d1ebea57a2bf825e16b0a717925b (diff)
downloadcoredns-75a8a17da4fc95c086dfb447d29c02e7dbd05561.tar.gz
coredns-75a8a17da4fc95c086dfb447d29c02e7dbd05561.tar.zst
coredns-75a8a17da4fc95c086dfb447d29c02e7dbd05561.zip
plugin/kubernetes: fix pod insecure mode (#1354)
Fixes #1331
Diffstat (limited to 'plugin/kubernetes/kubernetes.go')
-rw-r--r--plugin/kubernetes/kubernetes.go6
1 files changed, 6 insertions, 0 deletions
diff --git a/plugin/kubernetes/kubernetes.go b/plugin/kubernetes/kubernetes.go
index 4e79738e7..785a16ae3 100644
--- a/plugin/kubernetes/kubernetes.go
+++ b/plugin/kubernetes/kubernetes.go
@@ -321,6 +321,12 @@ func (k *Kubernetes) findPods(r recordRequest, zone string) (pods []msg.Service,
if !wildcard(namespace) && !k.namespace(namespace) { // no wildcard, but namespace does not exist
return nil, errNoItems
}
+
+ // If ip does not parse as an IP address, we return an error, otherwise we assume a CNAME and will try to resolve it in backend_lookup.go
+ if net.ParseIP(ip) == nil {
+ return nil, errNoItems
+ }
+
return []msg.Service{{Key: strings.Join([]string{zonePath, Pod, namespace, podname}, "/"), Host: ip, TTL: k.ttl}}, err
}