aboutsummaryrefslogtreecommitdiff
path: root/plugin/kubernetes/parse.go
diff options
context:
space:
mode:
authorGravatar Chris O'Haver <cohaver@infoblox.com> 2018-08-27 14:41:04 -0400
committerGravatar Miek Gieben <miek@miek.nl> 2018-08-27 19:41:04 +0100
commite6ef320d13580548a1ff9a36c3b1365240577ac1 (patch)
tree9c49324fdcc4685abd52940afedc5eefe3034a00 /plugin/kubernetes/parse.go
parent444472891ff124d656a247b63dd126240f5eb35b (diff)
downloadcoredns-e6ef320d13580548a1ff9a36c3b1365240577ac1.tar.gz
coredns-e6ef320d13580548a1ff9a36c3b1365240577ac1.tar.zst
coredns-e6ef320d13580548a1ff9a36c3b1365240577ac1.zip
handle blank name and namespaces (#2042)
Diffstat (limited to 'plugin/kubernetes/parse.go')
-rw-r--r--plugin/kubernetes/parse.go8
1 files changed, 4 insertions, 4 deletions
diff --git a/plugin/kubernetes/parse.go b/plugin/kubernetes/parse.go
index db7239827..60d2d3402 100644
--- a/plugin/kubernetes/parse.go
+++ b/plugin/kubernetes/parse.go
@@ -43,10 +43,10 @@ func parseRequest(state request.Request) (r recordRequest, err error) {
r.port = "*"
r.protocol = "*"
- r.service = "*"
- r.namespace = "*"
- // r.endpoint is the odd one out, we need to know if it has been set or not. If it is
- // empty we should skip the endpoint check in k.get(). Hence we cannot set if to "*".
+ // for r.name, r.namespace and r.endpoint, we need to know if they have been set or not...
+ // For endpoint: if empty we should skip the endpoint check in k.get(). Hence we cannot set if to "*".
+ // For name: myns.svc.cluster.local != *.myns.svc.cluster.local
+ // For namespace: svc.cluster.local != *.svc.cluster.local
// start at the right and fill out recordRequest with the bits we find, so we look for
// pod|svc.namespace.service and then either