diff options
| author |  Miek Gieben <miek@miek.nl>
| 2020-01-30 09:19:26 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-01-30 09:19:26 +0000 |
| commit | 995179a6c6f3eccbc04b20ff4961653d06c63551 (patch) | |
| tree | 0782daf1752f3aecb590232b14908eff119064e6 /plugin/kubernetes/setup.go | |
| parent | 488464b68668310cbdeb67ada3ff33dd13138f0b (diff) | |
| download | coredns-995179a6c6f3eccbc04b20ff4961653d06c63551.tar.gz coredns-995179a6c6f3eccbc04b20ff4961653d06c63551.tar.zst coredns-995179a6c6f3eccbc04b20ff4961653d06c63551.zip | |
presubmit: check import path ordering (#3636)
Add a test for this as well as it's annoying to point out in every code
review.
Fix all the import paths that are flagged by this new test.
Fixes: #3634
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/kubernetes/setup.go')
| -rw-r--r-- | plugin/kubernetes/setup.go | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/plugin/kubernetes/setup.go b/plugin/kubernetes/setup.go index b35d653e1..2c539bd6c 100644 --- a/plugin/kubernetes/setup.go +++ b/plugin/kubernetes/setup.go @@ -19,18 +19,11 @@ import ( "github.com/caddyserver/caddy" "github.com/miekg/dns" meta "k8s.io/apimachinery/pkg/apis/meta/v1" - - // Pull this in setting klog's output to stdout - "k8s.io/klog" - - // Excluding azure because it is failing to compile - // pull this in here, because we want it excluded if plugin.cfg doesn't have k8s - _ "k8s.io/client-go/plugin/pkg/client/auth/gcp" - // pull this in here, because we want it excluded if plugin.cfg doesn't have k8s - _ "k8s.io/client-go/plugin/pkg/client/auth/oidc" - // pull this in here, because we want it excluded if plugin.cfg doesn't have k8s - _ "k8s.io/client-go/plugin/pkg/client/auth/openstack" + _ "k8s.io/client-go/plugin/pkg/client/auth/gcp" // pull this in here, because we want it excluded if plugin.cfg doesn't have k8s + _ "k8s.io/client-go/plugin/pkg/client/auth/oidc" // pull this in here, because we want it excluded if plugin.cfg doesn't have k8s + _ "k8s.io/client-go/plugin/pkg/client/auth/openstack" // pull this in here, because we want it excluded if plugin.cfg doesn't have k8s "k8s.io/client-go/tools/clientcmd" + "k8s.io/klog" ) var log = clog.NewWithPlugin("kubernetes") |