diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-04-19 07:41:56 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-04-19 07:41:56 +0100 |
| commit | 26d1432ae6c19c91fb6358e7629a9179a85b70f7 (patch) | |
| tree | 8a9f94cf11dcebf1f079ab478d4ded4bf710c99f /plugin/kubernetes | |
| parent | 2095eb7979f53618180f759d0e68e4070554870d (diff) | |
| download | coredns-26d1432ae6c19c91fb6358e7629a9179a85b70f7.tar.gz coredns-26d1432ae6c19c91fb6358e7629a9179a85b70f7.tar.zst coredns-26d1432ae6c19c91fb6358e7629a9179a85b70f7.zip | |
Update all plugins to use plugin/pkg/log (#1694)
* Update all plugins to use plugin/pkg/log
I wish this could have been done with sed. Alas manually changed all
callers to use the new plugin/pkg/log package.
* Error -> Info
* Add docs to debug plugin as well
Diffstat (limited to 'plugin/kubernetes')
| -rw-r--r-- | plugin/kubernetes/apiproxy.go | 10 | ||||
| -rw-r--r-- | plugin/kubernetes/xfr.go | 5 |
2 files changed, 8 insertions, 7 deletions
diff --git a/plugin/kubernetes/apiproxy.go b/plugin/kubernetes/apiproxy.go index 097600096..a4d25879f 100644 --- a/plugin/kubernetes/apiproxy.go +++ b/plugin/kubernetes/apiproxy.go @@ -3,11 +3,11 @@ package kubernetes import ( "fmt" "io" - "log" "net" "net/http" "github.com/coredns/coredns/plugin/pkg/healthcheck" + "github.com/coredns/coredns/plugin/pkg/log" ) type proxyHandler struct { @@ -27,19 +27,19 @@ func (p *proxyHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { d, err := net.Dial(network, address) if err != nil { - log.Printf("[ERROR] Unable to establish connection to upstream %s://%s: %s", network, address, err) + log.Errorf("Unable to establish connection to upstream %s://%s: %s", network, address, err) http.Error(w, fmt.Sprintf("Unable to establish connection to upstream %s://%s: %s", network, address, err), 500) return } hj, ok := w.(http.Hijacker) if !ok { - log.Print("[ERROR] Unable to establish connection: no hijacker") + log.Error("Unable to establish connection: no hijacker") http.Error(w, "Unable to establish connection: no hijacker", 500) return } nc, _, err := hj.Hijack() if err != nil { - log.Printf("[ERROR] Unable to hijack connection: %s", err) + log.Errorf("Unable to hijack connection: %s", err) http.Error(w, fmt.Sprintf("Unable to hijack connection: %s", err), 500) return } @@ -48,7 +48,7 @@ func (p *proxyHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) { err = r.Write(d) if err != nil { - log.Printf("[ERROR] Unable to copy connection to upstream %s://%s: %s", network, address, err) + log.Errorf("Unable to copy connection to upstream %s://%s: %s", network, address, err) http.Error(w, fmt.Sprintf("Unable to copy connection to upstream %s://%s: %s", network, address, err), 500) return } diff --git a/plugin/kubernetes/xfr.go b/plugin/kubernetes/xfr.go index 44d9af70b..bd037db8c 100644 --- a/plugin/kubernetes/xfr.go +++ b/plugin/kubernetes/xfr.go @@ -1,14 +1,15 @@ package kubernetes import ( - "log" "math" "net" "strings" "github.com/coredns/coredns/plugin" "github.com/coredns/coredns/plugin/etcd/msg" + "github.com/coredns/coredns/plugin/pkg/log" "github.com/coredns/coredns/request" + "github.com/miekg/dns" "golang.org/x/net/context" api "k8s.io/api/core/v1" @@ -50,7 +51,7 @@ func (k *Kubernetes) Transfer(ctx context.Context, state request.Request) (int, records = append(records, soa...) go func(ch chan *dns.Envelope) { j, l := 0, 0 - log.Printf("[INFO] Outgoing transfer of %d records of zone %s to %s started", len(records), state.Zone, state.IP()) + log.Infof("Outgoing transfer of %d records of zone %s to %s started", len(records), state.Zone, state.IP()) for i, r := range records { l += dns.Len(r) if l > transferLength { |