diff options
| author |  Miek Gieben <miek@miek.nl>
| 2018-02-28 08:43:19 -0800 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2018-02-28 08:43:19 -0800 |
| commit | 928de738dd70e7074cdd563d2247305fe1fcad35 (patch) | |
| tree | 4a6789f3312e6355b34fa81881b0e6187aab3459 /plugin/kubernetes | |
| parent | 395b614349ad730af8edbae204a4744128e0b0f3 (diff) | |
| download | coredns-928de738dd70e7074cdd563d2247305fe1fcad35.tar.gz coredns-928de738dd70e7074cdd563d2247305fe1fcad35.tar.zst coredns-928de738dd70e7074cdd563d2247305fe1fcad35.zip | |
Rename reverse zone constants (#1568)
Rename the constants to IP4arpa and IP6arpa (shorter and exported) and
make IsReverse return the type of the reverse zone which could be handy
for some callers.
Also add tests for IsReverse()
Diffstat (limited to 'plugin/kubernetes')
| -rw-r--r-- | plugin/kubernetes/kubernetes.go | 2 | ||||
| -rw-r--r-- | plugin/kubernetes/setup.go | 5 |
2 files changed, 4 insertions, 3 deletions
diff --git a/plugin/kubernetes/kubernetes.go b/plugin/kubernetes/kubernetes.go index 92d0d5018..34dd47254 100644 --- a/plugin/kubernetes/kubernetes.go +++ b/plugin/kubernetes/kubernetes.go @@ -274,7 +274,7 @@ func (k *Kubernetes) Records(state request.Request, exact bool) ([]msg.Service, return nil, e } - if dnsutil.IsReverse(state.Name()) { + if dnsutil.IsReverse(state.Name()) > 0 { return nil, errNoItems } diff --git a/plugin/kubernetes/setup.go b/plugin/kubernetes/setup.go index 23ed4443a..7d41fb64d 100644 --- a/plugin/kubernetes/setup.go +++ b/plugin/kubernetes/setup.go @@ -9,9 +9,10 @@ import ( "github.com/coredns/coredns/core/dnsserver" "github.com/coredns/coredns/plugin" + "github.com/coredns/coredns/plugin/pkg/dnsutil" "github.com/coredns/coredns/plugin/pkg/parse" - "github.com/coredns/coredns/plugin/pkg/upstream" + "github.com/mholt/caddy" "github.com/miekg/dns" meta "k8s.io/apimachinery/pkg/apis/meta/v1" @@ -113,7 +114,7 @@ func ParseStanza(c *caddy.Controller) (*Kubernetes, error) { k8s.primaryZoneIndex = -1 for i, z := range k8s.Zones { - if strings.HasSuffix(z, "in-addr.arpa.") || strings.HasSuffix(z, "ip6.arpa.") { + if dnsutil.IsReverse(z) > 0 { continue } k8s.primaryZoneIndex = i |