diff options
| author |  Miek Gieben <miek@miek.nl>
| 2020-03-26 09:17:33 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-03-26 09:17:33 +0100 |
| commit | 19cfa2960cc415e0e38d36fc9d9325bd636c000e (patch) | |
| tree | 92862740f97d0378fb0f6dced375fb2d9442271a /plugin/metrics/metrics_test.go | |
| parent | eb23cce1a766ee37cbfc884928f668dac4d0ddff (diff) | |
| download | coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.gz coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.tar.zst coredns-19cfa2960cc415e0e38d36fc9d9325bd636c000e.zip | |
Cleanup metrics (#3776)
Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.
Signed-off-by: Ben Kochie <superq@gmail.com>
Co-authored-by: Ben Kochie <superq@gmail.com>
Diffstat (limited to 'plugin/metrics/metrics_test.go')
| -rw-r--r-- | plugin/metrics/metrics_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/plugin/metrics/metrics_test.go b/plugin/metrics/metrics_test.go index b0e311b73..1f63a20b7 100644 --- a/plugin/metrics/metrics_test.go +++ b/plugin/metrics/metrics_test.go @@ -31,25 +31,25 @@ func TestMetrics(t *testing.T) { { next: test.NextHandler(dns.RcodeSuccess, nil), qname: "example.org", - metric: "coredns_dns_request_count_total", + metric: "coredns_dns_requests_total", expectedValue: "1", }, { next: test.NextHandler(dns.RcodeSuccess, nil), qname: "example.org", - metric: "coredns_dns_request_count_total", + metric: "coredns_dns_requests_total", expectedValue: "2", }, { next: test.NextHandler(dns.RcodeSuccess, nil), qname: "example.org", - metric: "coredns_dns_request_type_count_total", + metric: "coredns_dns_requests_total", expectedValue: "3", }, { next: test.NextHandler(dns.RcodeSuccess, nil), qname: "example.org", - metric: "coredns_dns_response_rcode_count_total", + metric: "coredns_dns_responses_total", expectedValue: "4", }, } |