diff options
| author |  Miek Gieben <miek@miek.nl>
| 2019-01-19 11:23:13 +0000 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2019-01-19 11:23:13 +0000 |
| commit | 725becd134752caead1aa2b2cf3a72d01c13b599 (patch) | |
| tree | 300dbfeac60f6cffd86c3aeb0b68d772415e6521 /plugin/metrics/metrics_test.go | |
| parent | 278303ca0df6e6167788fa3435f6ea7c6253157b (diff) | |
| download | coredns-725becd134752caead1aa2b2cf3a72d01c13b599.tar.gz coredns-725becd134752caead1aa2b2cf3a72d01c13b599.tar.zst coredns-725becd134752caead1aa2b2cf3a72d01c13b599.zip | |
Stop importing testing in the main binary (#2479)
* Stop importing testing in the main binary
Stop importing "testing" into the main binary:
* test/helpers.go imported it; remote that and change function signature
* update all tests that use this
Signed-off-by: Miek Gieben <miek@miek.nl>
* Drop import testing from metrics plugin
Signed-off-by: Miek Gieben <miek@miek.nl>
* more fiddling
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/metrics/metrics_test.go')
| -rw-r--r-- | plugin/metrics/metrics_test.go | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/plugin/metrics/metrics_test.go b/plugin/metrics/metrics_test.go index 211abdb23..b0e311b73 100644 --- a/plugin/metrics/metrics_test.go +++ b/plugin/metrics/metrics_test.go @@ -5,7 +5,6 @@ import ( "testing" "github.com/coredns/coredns/plugin" - mtest "github.com/coredns/coredns/plugin/metrics/test" "github.com/coredns/coredns/plugin/pkg/dnstest" "github.com/coredns/coredns/plugin/test" @@ -71,10 +70,10 @@ func TestMetrics(t *testing.T) { t.Fatalf("Test %d: Expected no error, but got %s", i, err) } - result := mtest.Scrape(t, "http://"+ListenAddr+"/metrics") + result := test.Scrape("http://" + ListenAddr + "/metrics") if tc.expectedValue != "" { - got, _ := mtest.MetricValue(tc.metric, result) + got, _ := test.MetricValue(tc.metric, result) if got != tc.expectedValue { t.Errorf("Test %d: Expected value %s for metrics %s, but got %s", i, tc.expectedValue, tc.metric, got) } |