diff options
| author |  Miek Gieben <miek@miek.nl>
| 2020-10-30 10:27:04 +0100 |
|---|---|---|
| committer |  GitHub <noreply@github.com>
| 2020-10-30 10:27:04 +0100 |
| commit | c840caf1ef77d8f86ee7d11f644e0d6ea42c469a (patch) | |
| tree | 8fd3b097e41d1b04f737acfe92a7e81afe5db201 /plugin/metrics/metrics_test.go | |
| parent | bc0115d71f15aacc04d9ce9e8ce148b31d151800 (diff) | |
| download | coredns-c840caf1ef77d8f86ee7d11f644e0d6ea42c469a.tar.gz coredns-c840caf1ef77d8f86ee7d11f644e0d6ea42c469a.tar.zst coredns-c840caf1ef77d8f86ee7d11f644e0d6ea42c469a.zip | |
Speed up testing (#4239)
* Speed up testing
* make notification run in the background, this recudes the test_readme
time from 18s to 0.10s
* reduce time for zone reload
* TestServeDNSConcurrent remove entirely. This took a whopping 58s for
... ? A few minutes staring didn't reveal wth it is actually testing.
Making values smaller revealed race conditions in the tests. Remove
entirely.
* Move many interval values to variables so we can reset them to short
values for the tests.
* test_large_axfr: make the zone smaller. The number used 64K has no
rational, make it 64/10 to speed up.
* TestProxyThreeWay: use client with shorter timeout
A few random tidbits in other tests.
Total time saved: 177s (almost 3m) - which makes it worthwhile again to
run the test locally:
this branch:
~~~
ok github.com/coredns/coredns/test 10.437s
cd plugin; time go t ./...
5,51s user 7,51s system 11,15s elapsed 744%CPU (
~~~
master:
~~~
ok github.com/coredns/coredns/test 35.252s
cd plugin; time go t ./...
157,64s user 15,39s system 50,05s elapsed 345%CPU ()
~~~
tests/ -25s
plugins/ -40s
This brings the total on 20s, and another 10s can be saved by fixing
dnstapio. Moving this to 5s would be even better, but 10s is also nice.
Signed-off-by: Miek Gieben <miek@miek.nl>
* Also 0.01
Signed-off-by: Miek Gieben <miek@miek.nl>
Diffstat (limited to 'plugin/metrics/metrics_test.go')
| -rw-r--r-- | plugin/metrics/metrics_test.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/plugin/metrics/metrics_test.go b/plugin/metrics/metrics_test.go index 1f63a20b7..bd72bf1f4 100644 --- a/plugin/metrics/metrics_test.go +++ b/plugin/metrics/metrics_test.go @@ -30,25 +30,25 @@ func TestMetrics(t *testing.T) { // This all works because 1 bucket (1 zone, 1 type) { next: test.NextHandler(dns.RcodeSuccess, nil), - qname: "example.org", + qname: "example.org.", metric: "coredns_dns_requests_total", expectedValue: "1", }, { next: test.NextHandler(dns.RcodeSuccess, nil), - qname: "example.org", + qname: "example.org.", metric: "coredns_dns_requests_total", expectedValue: "2", }, { next: test.NextHandler(dns.RcodeSuccess, nil), - qname: "example.org", + qname: "example.org.", metric: "coredns_dns_requests_total", expectedValue: "3", }, { next: test.NextHandler(dns.RcodeSuccess, nil), - qname: "example.org", + qname: "example.org.", metric: "coredns_dns_responses_total", expectedValue: "4", }, @@ -61,7 +61,7 @@ func TestMetrics(t *testing.T) { if tc.qtype == 0 { tc.qtype = dns.TypeA } - req.SetQuestion(dns.Fqdn(tc.qname), tc.qtype) + req.SetQuestion(tc.qname, tc.qtype) met.Next = tc.next rec := dnstest.NewRecorder(&test.ResponseWriter{}) |